Describe suppression reason (#626)

DevExpress · Jul 9, 2024 · ed53b3e · ed53b3e
1 parent bacf9cf
commit ed53b3e
Show file tree

Hide file tree

Showing 6 changed files with 3 additions and 19 deletions.
diff --git a/net/DevExtreme.AspNet.Data.Tests.NH/RemoteGroupingStress.cs b/net/DevExtreme.AspNet.Data.Tests.NH/RemoteGroupingStress.cs
@@ -30,7 +30,7 @@ public DataItemMap() {
                 //Map(i => i.DateO); //used by all fixtures, requires nh feature support (see skip)
             }
         }
-#pragma warning disable xUnit1004
+#pragma warning disable xUnit1004 // skip until external / dependency reason is resolved
         [Fact(Skip = "Skip until https://github.com/nhibernate/nhibernate-core/issues/2912 is implemented?")]
 #pragma warning restore xUnit1004
         public async Task Scenario() {

diff --git a/net/DevExtreme.AspNet.Data.Tests.Xpo/RemoteGroupingStress.cs b/net/DevExtreme.AspNet.Data.Tests.Xpo/RemoteGroupingStress.cs
@@ -55,7 +55,7 @@ public DateOnly DateO {
             }
 //#endif
         }
-#pragma warning disable xUnit1004
+#pragma warning disable xUnit1004 // skip until external / dependency reason is resolved
         [Fact(Skip = "Skip until proper DevExpress.Xpo dll / nupkg with Date Time Only support?")]
 #pragma warning restore xUnit1004
         public async Task Scenario() {

diff --git a/net/DevExtreme.AspNet.Data.Tests/ResponseModelTests.cs b/net/DevExtreme.AspNet.Data.Tests/ResponseModelTests.cs
@@ -6,7 +6,7 @@
 namespace DevExtreme.AspNet.Data.Tests {
 
     public class ResponseModelTests {
-#pragma warning disable xUnit1004
+#pragma warning disable xUnit1004 // skip until external / dependency reason is resolved
         [Fact(Skip = "Skip until consolidation or target bump to net7 and ShouldSerialize")]
 #pragma warning restore xUnit1004
         public void EmptyLoadResultSerialization() {

diff --git a/net/DevExtreme.AspNet.Data/Async/ReflectionAsyncAdapter.cs b/net/DevExtreme.AspNet.Data/Async/ReflectionAsyncAdapter.cs
@@ -64,9 +64,7 @@ static class EF6Methods {
             public static readonly MethodInfo CountAsyncMethod;
             public static readonly MethodInfo ToListAsyncMethod;
             static EF6Methods() {
-#pragma warning disable DX0004
                 var extensionsType = Type.GetType("System.Data.Entity.QueryableExtensions, EntityFramework");
-#pragma warning restore DX0004
                 CountAsyncMethod = FindCountAsyncMethod(extensionsType);
                 ToListAsyncMethod = FindToListAsyncMethod(extensionsType);
             }
@@ -76,9 +74,7 @@ static class EFCoreMethods {
             public static readonly MethodInfo CountAsyncMethod;
             public static readonly MethodInfo ToListAsyncMethod;
             static EFCoreMethods() {
-#pragma warning disable DX0004
                 var extensionsType = Type.GetType("Microsoft.EntityFrameworkCore.EntityFrameworkQueryableExtensions, Microsoft.EntityFrameworkCore");
-#pragma warning restore DX0004
                 CountAsyncMethod = FindCountAsyncMethod(extensionsType);
                 ToListAsyncMethod = FindToListAsyncMethod(extensionsType);
             }
@@ -88,9 +84,7 @@ static class NHMethods {
             public static readonly MethodInfo CountAsyncMethod;
             public static readonly MethodInfo ToListAsyncMethod;
             static NHMethods() {
-#pragma warning disable DX0004
                 var extensionsType = Type.GetType("NHibernate.Linq.LinqExtensionMethods, NHibernate");
-#pragma warning restore DX0004
                 CountAsyncMethod = FindCountAsyncMethod(extensionsType);
                 ToListAsyncMethod = FindToListAsyncMethod(extensionsType);
             }
@@ -101,9 +95,7 @@ static class XpoMethods {
             public static readonly MethodInfo ToArrayAsyncMethod;
             static XpoMethods() {
                 var asm = Array.Find(AppDomain.CurrentDomain.GetAssemblies(), a => a.FullName.StartsWith("DevExpress.Xpo.v"));
-#pragma warning disable DX0004
                 var extensionsType = asm.GetType("DevExpress.Xpo.XPQueryExtensions");
-#pragma warning restore DX0004
                 CountAsyncMethod = FindCountAsyncMethod(extensionsType);
                 ToArrayAsyncMethod = FindToArrayAsyncMethod(extensionsType);
             }

diff --git a/net/DevExtreme.AspNet.Data/QueryProviderInfo.cs b/net/DevExtreme.AspNet.Data/QueryProviderInfo.cs
@@ -38,16 +38,12 @@ public QueryProviderInfo(IQueryProvider provider) {
                     switch(providerAssembly.GetName().Name) {
                         case "LinqKit.Microsoft.EntityFrameworkCore":
                             IsEFCore = true;
-#pragma warning disable DX0010
                             providerAssembly = Assembly.Load("Microsoft.EntityFrameworkCore");
-#pragma warning restore DX0010
                             break;
 
                         case "LinqKit.EntityFramework":
                             IsEFClassic = true;
-#pragma warning disable DX0010
                             providerAssembly = Assembly.Load("EntityFramework");
-#pragma warning restore DX0010
                             break;
                     }
                 }

diff --git a/net/DevExtreme.AspNet.Data/Types/DynamicClassBridge.cs b/net/DevExtreme.AspNet.Data/Types/DynamicClassBridge.cs
@@ -16,14 +16,10 @@ static readonly MethodInfo
 
         static DynamicClassBridge() {
             try {
-#pragma warning disable DX0010
                 var assembly = Assembly.Load("System.Linq.Dynamic.Core");
-#pragma warning restore DX0010
-#pragma warning disable DX0004
                 FACTORY_TYPE = assembly.GetType("System.Linq.Dynamic.Core.DynamicClassFactory");
                 CLASS_TYPE = assembly.GetType("System.Linq.Dynamic.Core.DynamicClass");
                 PROP_TYPE = assembly.GetType("System.Linq.Dynamic.Core.DynamicProperty");
-#pragma warning restore DX0004
                 CREATE_TYPE_METHOD = FACTORY_TYPE.GetMethod("CreateType");
                 INDEXER_METHOD = CLASS_TYPE.GetMethod("get_Item");
             } catch(FileNotFoundException x) {