feat: FDN-278 - SDKConfig Event #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hey @JamieSinn - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
| @@ -434,12 +436,34 @@ func TestClient_Validate_OnInitializedChannel_EnableCloudBucketing_Options(t *te | |||
| t.Fatal("Expected config to be loaded") | |||
| } | |||
| } | |||
| func TestClient_ConfigUpdatedEvent(t *testing.T) { | |||
There was a problem hiding this comment.
suggestion: Consider adding a comment to explain the purpose of this test.
Adding a brief comment at the beginning of the test function can help future maintainers understand the purpose and context of this test.
Suggested change
| func TestClient_ConfigUpdatedEvent(t *testing.T) { | |
| func TestClient_ConfigUpdatedEvent(t *testing.T) { | |
| // Test to ensure the client correctly handles configuration update events |
| @@ -113,6 +115,30 @@ func (e *EventManager) QueueVariableDefaultedEvent(variableKey string, defaultRe | |||
| return e.internalQueue.QueueVariableDefaulted(variableKey, defaultReason) | |||
| } | |||
|
|
|||
| func (e *EventManager) QueueSDKConfigEvent(req http.Request, resp http.Response) error { | |||
There was a problem hiding this comment.
suggestion: Consider handling potential errors from QueueEvent.
Even though the comment mentions that it's best effort, logging the error might be useful for debugging purposes.
Suggested change
| func (e *EventManager) QueueSDKConfigEvent(req http.Request, resp http.Response) error { | |
| func (e *EventManager) QueueSDKConfigEvent(req http.Request, resp http.Response) error { | |
| uuid := e.GetUUID() | |
| user := api.User{UserId: uuid} | |
| err := e.internalQueue.QueueVariableDefaulted(variableKey, defaultReason) | |
| if err != nil { | |
| log.Printf("Error queuing SDK config event: %v", err) | |
| } | |
| return err | |
| } |
event_manager_test.go
Outdated
| @@ -76,7 +77,7 @@ func TestEventManager_QueueEvent_100_Flush(t *testing.T) { | |||
| // Wait for raw event queue to drain | |||
| require.Eventually(t, func() bool { | |||
| queueLength, _ := c.eventQueue.internalQueue.UserQueueLength() | |||
| return queueLength == 10 | |||
| return queueLength-startingLength >= 10 | |||
There was a problem hiding this comment.
what is the OOO here?
Suggested change
| return queueLength-startingLength >= 10 | |
| return ((queueLength - startingLength) >= 10) |
There was a problem hiding this comment.
Forgot to remove - this is from testing
jonathannorris
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.