enhance(client): html-app-container css #1476
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Move and change
.html-app-container
CSS.PR Status:
Note
After prod deploy, delete
<style …>…</style>
from HTML of each such variant. (See "Notes".)Related Jira tickets:
Summary of Changes:
Testing Steps:
Warning
Not deployed to dev. To test, do so locally.
._html-app-container_...
is on the wrapper div (from workspace code).<p>
’s inside have extra margin (margin-block: 1em 2em
).UI Photos:
Notes:
The result on existing app entry variants HML is uglier, but the new styles are meant for the new HTML, which is already on prod e.g. EE-UQ (prod).
I hacked the styles onto production by including them in the "HTML" of every such app variant.
Stakeholder has been asked to review.