Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DSAPP-57 alignment of app card hazard tags #1474

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

wesleyboar
Copy link
Collaborator

@wesleyboar wesleyboar commented Oct 10, 2024

Overview:

Fix alignment of gray box of hazard tags on an app card on Tools & Apps page.

PR Status:

  • Ready.

Important

To self:

  1. If approved, publish page (to activate snippet).
  2. If deployed, delete snippet.

Related Jira tickets:

Summary of Changes:

  • changed version of Core-Styles for c-app-card
  • added forced height on c-app-card description

Testing Steps:

  1. Replicate layout on prod with code from this branch:
  2. Change window width and/or zoom until you have:
    • one column "Simulation" full width
    • three columns of cards:
      • one has two-line gray box, one-line desc
      • one has one-line gray box, one-line desc
      • one has one-line gray box, two-line desc
  3. Verify alignment of gray boxes is consistent.

UI Photos:

before after
before after

Notes:

Snippet to Replicate this Change
<style id="css-dsapp-57-fix-app-card-hazard-alignment">
/* https://github.com/DesignSafe-CI/portal/pull/1474/files#diff-4fc2ef0ac0e52e3482998ece7245f66b5fe995dace36982b98a561f73a723283R4 */
@import url("https://cdn.jsdelivr.net/npm/@tacc/[email protected]/dist/components/c-app-card.css");

/* https://github.com/DesignSafe-CI/portal/pull/1474/files#diff-4fc2ef0ac0e52e3482998ece7245f66b5fe995dace36982b98a561f73a723283R27-R31 */
.c-app-card__desc {
    height: 3.6em;
}
</style>

@import url("https://cdn.jsdelivr.net/gh/TACC/core-styles@v2.26.0/dist/components/c-app-card.css");
@import url("https://cdn.jsdelivr.net/npm/@tacc/core-styles@v2.35.0/dist/components/c-app-card.css");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relevant change is TACC/Core-Styles#405.

Copy link
Contributor

@sophia-massie sophia-massie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks Wes

@rstijerina rstijerina merged commit 6ac0731 into main Oct 11, 2024
5 checks passed
@rstijerina rstijerina deleted the fix/DSAPP-57-alignment-of-app-card-desc branch October 11, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants