task/WP-708: add unit tests and refactor getting toolbar rules into a method #1457
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanfranklin
changed the title
jarosenb
requested changes
Oct 4, 2024
client/modules/datafiles/src/DatafilesToolbar/DatafilesToolbar.tsx
Outdated
Show resolved
Hide resolved
…com:DesignSafe-CI/portal into task/WP-708-unit-tests-for-DatafilesToolbar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
This PR adds unit tests as a follow-up to WP-707
Getting toolbar rules is refactored into a method to make unit testing easier.
PR Status:
Related Jira tickets:
Testing Steps:
Notes
Do we want these simple file fixtures to be moved somewhere in
client/modules/_test-fixtures/src/fixtures?