Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Quick: fix case when job.tags is null #1454

Merged
merged 1 commit into from
Oct 2, 2024
Merged

Quick: fix case when job.tags is null #1454

merged 1 commit into from
Oct 2, 2024

Conversation

rstijerina
Copy link
Member

Overview:

Handle case where job.tags is null.

PR Status:

  • Ready.

Testing Steps:

  1. Comment out

    portal/designsafe/apps/workspace/api/views.py

    Lines 781 to 784 in 6f5520c

    job_post["tags"] = job_post.get("tags", []) + [
    f"portalName: {settings.PORTAL_NAMESPACE}"
    ]
  2. Submit a non-interactive job
  3. Confirm that "View Details" modal works properly

chandra-tacc
chandra-tacc approved these changes Oct 2, 2024
View reviewed changes
Copy link
Contributor

@chandra-tacc chandra-tacc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested. LGTM.
Commented out another place of tags usage in api to get the submission working.

@rstijerina rstijerina merged commit 88c67db into main Oct 2, 2024
5 checks passed
@rstijerina rstijerina deleted the quick/fix-missing-tags branch October 2, 2024 22:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chandra-tacc chandra-tacc chandra-tacc approved these changes

@jarosenb jarosenb jarosenb approved these changes

@fnets fnets Awaiting requested review from fnets

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rstijerina @chandra-tacc @jarosenb