Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

task/DES-2609: App Form Updates #1123

Merged
merged 5 commits into from
Nov 10, 2023
Merged

task/DES-2609: App Form Updates #1123

merged 5 commits into from
Nov 10, 2023

Conversation

rstijerina
Copy link
Member

Overview:

  • Fix validation fields
  • Change display text for some fields
  • Hide "Inputs" if none are defined
  • Fix max, min, and default values for some fields

PR Status:

  • Ready.

Related Jira tickets:

Testing Steps:

  1. Go to https://designsafe.dev/rw/workspace/#!/OpenSees::Simulation
  2. Confirm UI matches screenshots
  3. Confirm apps submit and function correctly

UI Photos:

Screenshot 2023-11-08 at 2 56 21 PM
Screenshot 2023-11-08 at 2 56 32 PM

fnets
fnets approved these changes Nov 9, 2023
View reviewed changes
Copy link
Contributor

@fnets fnets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and works locally

@jarosenb jarosenb merged commit de7303b into main Nov 10, 2023
2 checks passed
@jarosenb jarosenb deleted the task/DES-2609--app-form-updates branch November 10, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fnets fnets fnets approved these changes

@jarosenb jarosenb Awaiting requested review from jarosenb

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rstijerina @fnets @jarosenb