New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DES-2598 text editor too short (⚠️ untested) #1102

Merged

jarosenb merged 2 commits into main from fix/DES-2598-text-editor-source-view-too-short-in-narrow-modal

Oct 5, 2023

Collaborator

wesleyboar commented Oct 4, 2023

Overview:

Add styles to CMS Text editor stylesheet to prevent field size bug.

PR Status:

Ready… but untested locally.
Work in Progress.
Hold.

Related Jira tickets:

DES-2598

Summary of Changes:

added custom stylesheet for ckeditor
added clone of original stylesheet for ckeditor
added import of cloned stylesheet

Testing Steps:

Open CMS.
Login as admin.
Create/Edit text on a page.
Add so much content, a scrollbar is needed.
Make the text editor modal narrow.
While editing, view source (click the "[<>] Source" button).
Verify all available height in modal for text editor is used to show source.

UI Photos:

I am unable to provide. I do not have test environemnt.

Notes:


fix: DES-2598 text editor too short — ⚠️ untested

4bba425

1. stole code from https://github.com/TACC/Core-CMS/pull/573/files#diff-b613bf1b786994b3d51a81e982cf9106f4a09f8adcc65fd9c14f4f8d54bdfa72R6-R8
2. applied code like https://github.com/TACC/Core-CMS/blob/v4.0.0/taccsite_cms/static/djangocms_text_ckeditor/ckeditor/contents.css

wesleyboar changed the title ~~fix: DES-2598 text editor too short — ⚠️ untested~~ fix: DES-2598 text editor too short (⚠️ untested)


fix import path

8b4fb62

jarosenb merged commit 9daf83a into main

2 checks passed

jarosenb deleted the fix/DES-2598-text-editor-source-view-too-short-in-narrow-modal branch

October 5, 2023 14:58

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment