Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Node to v16 inside Docker container #1077

Merged
merged 4 commits into from
Jul 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
- name: Setup Node.js for use with actions
uses: actions/setup-node@v1
with:
node-version: 12.x
node-version: 16.x

- uses: actions/cache@v1
with:
Expand Down
7 changes: 5 additions & 2 deletions conf/docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -27,8 +27,8 @@ RUN apt-get update && apt-get install -y \
git \
vim

# install node 12.x
RUN curl -sL https://deb.nodesource.com/setup_12.x | bash -
# install node 16.x
RUN curl -sL https://deb.nodesource.com/setup_16.x | bash -
RUN apt-get install -y nodejs

RUN pip install poetry
Expand All @@ -49,3 +49,6 @@ USER tg458981
RUN echo "prefix=~/.npm-global" >> ~/.npmrc

WORKDIR /srv/www/designsafe

RUN npm ci
RUN npm run build
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,6 @@
<script type="text/javascript" src="{% static 'vendor/objectpath/lib/ObjectPath.js' %}"></script>
<script type="text/javascript" src="{% static 'vendor/angular-schema-form/dist/schema-form.js' %}"></script>
<script type="text/javascript" src="{% static 'vendor/angular-schema-form/dist/bootstrap-decorator.js' %}"></script>
<script type="text/javascript" src="{% static 'vendor/angular-drag-and-drop-lists/angular-drag-and-drop-lists.js' %}"></script>
<script type="text/javascript" src="{% static 'vendor/angular-xeditable/dist/js/xeditable.js' %}"></script>
<script type="text/javascript" src="{% static 'vendor/codemirror/lib/codemirror.js' %}"></script>
<script type="text/javascript" src="{% static 'vendor/angular-ui-codemirror/src/ui-codemirror.js' %}"></script>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@
<script type="text/javascript" src="{% static 'vendor/objectpath/lib/ObjectPath.js' %}"></script>
<script type="text/javascript" src="{% static 'vendor/angular-schema-form/dist/schema-form.js' %}"></script>
<script type="text/javascript" src="{% static 'vendor/angular-schema-form/dist/bootstrap-decorator.js' %}"></script>
<script type="text/javascript" src="{% static 'vendor/angular-drag-and-drop-lists/angular-drag-and-drop-lists.js' %}"></script>
<script type="text/javascript" src="{% static 'vendor/angular-xeditable/dist/js/xeditable.js' %}"></script>
<script src="{% static 'vendor/angular-ui-codemirror/src/ui-codemirror.js' %}"></script>
{% endaddtoblock %}
Expand Down
1 change: 0 additions & 1 deletion designsafe/settings/common_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,6 @@
('vendor/font-awesome', os.path.join(BASE_DIR, 'node_modules', 'font-awesome')),
('vendor/angular-toastr', os.path.join(BASE_DIR, 'node_modules', 'angular-toastr')),
('vendor/slick-carousel', os.path.join(BASE_DIR, 'node_modules', 'slick-carousel')),
('vendor/angular-drag-and-drop-lists', os.path.join(BASE_DIR, 'node_modules', 'angular-drag-and-drop-lists')),
('vendor/angular-xeditable', os.path.join(BASE_DIR, 'node_modules', 'angular-xeditable')),
('vendor/leaflet-measure', os.path.join(BASE_DIR, 'node_modules', 'leaflet-measure')),
('vendor/exif-js', os.path.join(BASE_DIR, 'node_modules', 'exif-js')),
Expand Down
1 change: 1 addition & 0 deletions designsafe/static/scripts/applications/app.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import $ from 'jquery';
import angular from 'angular';
import _ from 'underscore';
import dndlists from 'angular-drag-and-drop-lists';

import './services/apps-wizard-service';

Expand Down
1 change: 1 addition & 0 deletions designsafe/static/scripts/workspace/app.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import $ from 'jquery';
import angular from 'angular';
import _ from 'underscore';
import dndlists from 'angular-drag-and-drop-lists';


import { agaveFilePicker } from '../workspace/directives/agave-file-picker';
Expand Down
2 changes: 1 addition & 1 deletion designsafe/static/styles/ng-designsafe-ef.css
Original file line number Diff line number Diff line change
Expand Up @@ -755,7 +755,7 @@ a[ng-click]:hover {

@font-face {
font-family: 'DesignSafe-Apps';
src: url('/static/fonts/DesignSafe-App-Icons.ttf') format('truetype');
src: url('/static/fonts/Tools-and-Applications-Icons.ttf') format('truetype');
font-weight: normal;
font-style: normal;
}
Expand Down
2,601 changes: 1,493 additions & 1,108 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@
"clean-webpack-plugin": "^3.0.0",
"css-loader": "^5.0.0",
"elasticdump": "^3.3.7",
"eslint": "^7.2.0",
"eslint": "^6.0.0",
"eslint-config-airbnb-base": "^14.2.0",
"eslint-config-prettier": "^6.7.0",
"eslint-config-standard": "^14.1.0",
Expand Down
Loading