task/DES-2557: Allow EF sites to be displayed using recent Designsafe releases #1076
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
At some point in 2020 we inverted the colors on the main Designsafe menu and stretched the container to fill the screen horizontally. This breaks the EF sites, which still rely on Bootstrap 3 style container styling. This PR adds our old stylesheets back into version control for use on the EF sites.
PR Status:
Related Jira tickets:
Summary of Changes:
ng-designsafe.cssandmain.csswhen rendering EF site templates.Testing Steps:
common.pyedit the SITE_ID setting to anywhere between 2 and 10 to test out the rendering of the EF sties.UI Photos:
SimCenter site running in local dev:
Notes: