Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

des-2509-sim-type-missing-in-pub-pipeline #1075

Merged
merged 4 commits into from
Jul 19, 2023

Conversation

van-go
Copy link
Contributor

@van-go van-go commented Jul 10, 2023

Overview:

Simulation Type was missing from the Publication Pipeline.
While I was fixing that, I noticed that 'Date of Publication' was blank when on the Versioning screen. I looked at FR and Exp and noticed that on the Versioning screen, Date of Publication simply wasn't there. I think this was done because getting the correct date for a published versus unpublished project was difficult. So like FR and Exp, I removed Date of Publication

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

For the Simulation Type, the issue was a bad copy-paste. The code was looking for ‘experimentType’ instead of ‘simulationType’. That's been fixed.

For the Date of Publication, I commented out that part in the code.

Testing Steps:

  1. Find a Simulation Project
  2. Progress down the publication pipeline
  3. Check that Sim Type appears correctly
  4. Check that in Pub Preview, DoP appears as "Appears in Published" for a published project, and "Appears when Published" for a non-published project.
  5. Check that when amending a Sim Project, the correct date appears for DoP.
  6. Check that when versioning a Sim project, DoP does not appear.

UI Photos:

Screen Shot 2023-07-10 at 4 11 19 PM

Notes:

At some point, we need to fix the Date of Publication when Versioning for all project types. (needs a ticket, maybe)

Copy link
Member

@jarosenb jarosenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this!

@jarosenb jarosenb merged commit 1fc5765 into main Jul 19, 2023
2 checks passed
@jarosenb jarosenb deleted the des-2509-sim-type-missing-in-pub-pipeline branch July 19, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants