des-2509-sim-type-missing-in-pub-pipeline #1075
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview:
Simulation Type was missing from the Publication Pipeline.
While I was fixing that, I noticed that 'Date of Publication' was blank when on the Versioning screen. I looked at FR and Exp and noticed that on the Versioning screen, Date of Publication simply wasn't there. I think this was done because getting the correct date for a published versus unpublished project was difficult. So like FR and Exp, I removed Date of Publication
PR Status:
Related Jira tickets:
Summary of Changes:
For the Simulation Type, the issue was a bad copy-paste. The code was looking for ‘experimentType’ instead of ‘simulationType’. That's been fixed.
For the Date of Publication, I commented out that part in the code.
Testing Steps:
UI Photos:
Notes:
At some point, we need to fix the Date of Publication when Versioning for all project types. (needs a ticket, maybe)