Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task/des 2513 referenced data text changes #1073

Merged
merged 7 commits into from
Jul 19, 2023

Conversation

van-go
Copy link
Contributor

@van-go van-go commented Jul 7, 2023

Overview:

Changes to the text: Referenced Data

PR Status:

  • Ready.
  • Work in Progress.
  • Hold.

Related Jira tickets:

Summary of Changes:

Changed Referenced Data to Referenced Data and Software
Changed Add another Referenced Data to Add Another Referenced Data/Software
Changed Remove Referenced Data to Remove Referenced Data/Software

Testing Steps:

My Projects

  1. When creating a new project, the new text should appear in the form
  2. In the curation model, the new text should appear.
  3. When publishing, in the Proofread {ProjType}, when you click Edit, new text should appear.
  4. When amending a project, click Edit {ProjType} Metadata, new text should appear.

Published

  1. Projects that have a ref data should now show Referenced Data and Software

UI Photos:

Screen Shot 2023-07-07 at 1 52 33 PM
Screen Shot 2023-07-07 at 1 49 20 PM

Notes:

On the Edit/Add {ProjType} page, I didn't change "URL or DO for the referenced data, in URL format" because that would have made it two lines, and it didn't look good.

Also, I made this it's own ticket because of the large amount of file changes.

Copy link
Member

@jarosenb jarosenb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for these updates!

@jarosenb jarosenb merged commit 3117927 into main Jul 19, 2023
2 checks passed
@jarosenb jarosenb deleted the task/des-2513-referenced-data-text-changes branch July 19, 2023 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants