Draft: read in changes to parameters in set_parameter #1632
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The parameters definition is cached and thus edits to parameters made by set_parameter function were not picked up. These lines check with the stored parameter values and update these of needed.
update ensembble number like in set_timeseries
|
In GitLab by @Ailbhemit on Aug 4, 2023, 10:40 requested review from @SGeeversAtVortech |
|
In GitLab by @SGeeversAtVortech on Aug 4, 2023, 11:29 Commented on src/rtctools/data/storage.py line 276 I would expect that this function does not change values, only returns values. |
|
In GitLab by @jarsarasty on Sep 12, 2023, 11:48 Commented on src/rtctools/data/storage.py line 276 Hi @Ailbhemit, are there any updates on this MR? |
We found a work around in models to just set with io parameters and call io parameters directly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In GitLab by @Ailbhemit on Aug 4, 2023, 10:40
The parameters definition is cached and thus edits to parameters made
by set_parameter function were not picked up. These lines check with
the stored parameter values and update these of needed.