Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Link LAI and landuse classes #273
Link LAI and landuse classes #273
Changes from all commits
f27a26f
c1db0b1
13b296a
e5a0847
5635b0d
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option is mentioned here to use the landuse map of the Wflow model. This option does not appear in
setup_lai_from_lulc_mapping
, at least not explicitly (one could load the landuse map as a DataArray and pass it to the method). Is that something to add as a functionality to the method? Or remove the remark here if it is not implemented?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If someone derives the landuse maps for wflow, he/she will likely use
setup_lulc
to generate the map. And in that case, it would make more sense to use the original lulc data than using the staticmap itself. Or am I maybe missing a specific use case?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good question! Well you can always add the wflow staticmaps to your data catalog and I can imagine when you create a landuse scenario (eg crops into forest), you can update the original landuse map or decide to copy and update the wflow landuse map. I think it's always better to modify the original data but you never know.