Update USLE C parameter with planted forest and orchard values #234
Conversation
hydromt_wflow/wflow_sediment.py
Outdated
| if not isfile(fn_map) and fn_map not in self.data_catalog: | ||
| raise ValueError(f"Riverbed sediment mapping file not found: {fn_map}") |
There was a problem hiding this comment.
Do we still need this, this is caught by the DataCatalog right?
There was a problem hiding this comment.
If so, this could then also be removed from the WflowModel object
There was a problem hiding this comment.
Indeed. We often forget to update wflow_sediment with new changes so with this PR, I already chnaged what I saw including adding typing. I missed this one and now removed the line in wflow_sediment.
I did not find the place you meant in WflowModel object though... Thought I removed all those in a specific PR already?
There was a problem hiding this comment.
Line 907 in setup_lulc_maps
| @@ -15,6 +15,7 @@ Added | |||
| - New setup method for the **KsatHorFrac** parameter **setup_ksathorfarc** to up-downscale existing ksathorfrac maps. `PR #255 <https://github.com/Deltares/hydromt_wflow/pull/255>`_ | |||
| - new function **setup_pet_forcing** to reproject existing pet data rather than computing from other meteo data. PR #257 | |||
| - Workflow to compute brooks corey c for the wflow layers based on soilgrids data, soilgrids_brooks_corey. PR #242 | |||
| - **setup_lulcmaps** for wflow_sediment: if planted forest data is available, it can be used to update the values of the USLE C parameter. PR #234 | |||
There was a problem hiding this comment.
| - **setup_lulcmaps** for wflow_sediment: if planted forest data is available, it can be used to update the values of the USLE C parameter. PR #234 | |
| - **setup_lulcmaps** for wflow_sediment: if planted forest data is available, it can be used to update the values of the USLE C parameter. `PR #234 <https://github.com/Deltares/hydromt_wflow/pull/234>`_ |
PR link? I notice that we sometimes do and sometimes don't.
There was a problem hiding this comment.
So we should be consistent but in hydromt we only put the PR number and not the link anymore. Let's do that in the release PR.
There are two pages where the changes appear:
- release tag: there if you just put the PR number the link appear automatically but the rst link really does not.
- changelog doc: there the links do not appear.
What do you think is best? I think for the release, we generate the note automatically from the changelog so I don't know if we can update the links easily unless we decide to generate it manually again? If not then we should just put the Pr number and not the link.
There was a problem hiding this comment.
The site we can regenerate. The links in the release when can just edit afterwards. But maybe it becomes a bit of a hassle so we could opt to leave the link out.
Issue addressed
No issues opened. By default forest USLE C (erosion) is very small 0.001 while in literature, planted forest is 0.0881 and orchard even 0.2188. Shapefile data from Global Forest Watch is available to refine the landuse map with planted forest so this can be use to get better USLE C values. This PR adresses this.
Explanation
Burn planted forest and orchard in the USLE C and update values.
Checklist
mainAdditional Notes (optional)
Add any additional notes or information that may be helpful.