Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check leaky Terminals #1856

Closed
wants to merge 2 commits into from
Closed

Check leaky Terminals #1856

wants to merge 2 commits into from

Conversation

visr
Copy link
Member

@visr visr commented Oct 1, 2024

@evetion
Copy link
Member

evetion commented Oct 1, 2024

Integration tests shows the same warnings as I've found locally:

https://dpcbuild.deltares.nl/buildConfiguration/Ribasim_IntegrationTest_Linux/4605553?mode=branches&hideTestsFromDependencies=false&hideProblemsFromDependencies=false&buildTab=log&focusLine=737&logView=linear&linesState=123

So this is either an edge case (or misunderstanding) of flow_update_on_edge or some previously unknown solver behavior. Note that the results, water balance and all seem fine.

@visr visr mentioned this pull request Oct 1, 2024
Closed
@visr
Copy link
Member Author

visr commented Oct 8, 2024

With #1874 this is now never larger than 1e-8, and short. Closing this, it was never meant to be merged.

@visr visr closed this Oct 8, 2024
@visr visr deleted the check-warn branch October 8, 2024 11:21
@visr visr mentioned this pull request Oct 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@visr @evetion