Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

move codes #33

Merged
merged 9 commits into from
Nov 8, 2023
Merged

move codes #33

merged 9 commits into from
Nov 8, 2023

Conversation

d2hydro
Copy link
Contributor

@d2hydro d2hydro commented Nov 7, 2023

No description provided.

@d2hydro d2hydro requested a review from visr November 7, 2023 14:14
@d2hydro d2hydro self-assigned this Nov 7, 2023
visr
visr requested changes Nov 7, 2023
View reviewed changes
src/ribasim_nl/tests/test_code_utils.py Outdated Show resolved Hide resolved
pixi.lock Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
pixi.toml Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
pixi.toml Outdated Show resolved Hide resolved
visr
visr approved these changes Nov 8, 2023
View reviewed changes
Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@d2hydro this fails tests because the GeoPackage it tried to download then upload isn't found anymore. Could you fix these tests? Otherwise this is good to go.

@d2hydro
Copy link
Contributor Author

d2hydro commented Nov 8, 2023

@d2hydro this fails tests because the GeoPackage it tried to download then upload isn't found anymore. Could you fix these tests? Otherwise this is good to go.

Will fest in #34 as I am updating the cloud there

@d2hydro d2hydro closed this Nov 8, 2023
@d2hydro d2hydro reopened this Nov 8, 2023
@d2hydro d2hydro merged commit 7f0b3fc into main Nov 8, 2023
4 of 6 checks passed
@d2hydro d2hydro deleted the codes branch November 8, 2023 17:14
@d2hydro d2hydro removed their assignment Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@visr visr visr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@d2hydro @visr @DanielTollenaar