AGV reproducible parse_crossings #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
visr
commented
Oct 21, 2024
Comment on lines
-28
to
+30
| init_settings, crossing_settings = waterschap_struct.values() | ||
| init_settings["logfile"] = pathlib.Path(init_settings["output_path"]).with_suffix("").with_suffix(".log") | ||
| crossing_settings = waterschap_struct["find_crossings_with_peilgebieden"] | ||
| init_settings = waterschap_struct["init"] | ||
| init_settings["logfile"] = pathlib.Path(init_settings["output_path"]).with_suffix(".log") |
There was a problem hiding this comment.
The order of the waterschap_struct.values() changed, so this was no longer correct.
And with_suffix replaces any existing suffix, so a single call is sufficient.
visr
commented
Oct 21, 2024
Comment on lines
+20
to
+22
| init_settings["gpkg_path"] = verwerkt_dir / "postprocessed.gpkg" | ||
| init_settings["krw_path"] = cloud.joinpath("Basisgegevens/KRW/KRW_lichamen_per_waterschap.gpkg") | ||
| init_settings["output_path"] = verwerkt_dir / "crossings.gpkg" |
There was a problem hiding this comment.
This overwrites the waterschappen.py for now to avoid breaking other code.
rbruijnshkv
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This creates a new script
src\peilbeheerst_model\parse_crossings\AmstelGooienVecht.pythat is hooked up to thegoodcloud.I left the one with all waterboards intact. In the new script I didn't include the plotting code.