Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run post-process_agv.py #172

Merged
merged 3 commits into from
Oct 21, 2024
Merged

Run post-process_agv.py #172

merged 3 commits into from
Oct 21, 2024

Conversation

visr
Copy link
Member

@visr visr commented Oct 21, 2024

No description provided.

rbruijnshkv
rbruijnshkv requested changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@rbruijnshkv rbruijnshkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If 'afsluitmiddel' is changed back to 'aggregation_area,' the code will be ready for merging.

src/peilbeheerst_model/peilbeheerst_model/postprocess_data/post-process_agv.py Outdated
@@ -55,7 +47,7 @@
"duikersifonhevel",
"peilgebied",
"streefpeil",
"aggregation_area",
"afsluitmiddel",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We hebben er voor gekozen om niet met Afsluitmiddel data te werken, dus die kan er uit blijven. aggregation_area is daarentegen wel vereist om mee te geven. Dus als dat terug gezet kan worden is het klaar om gemerged te worden.

rbruijnshkv
rbruijnshkv approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@rbruijnshkv rbruijnshkv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@visr visr merged commit 13bc125 into main Oct 21, 2024
4 checks passed
@visr visr deleted the post-the-agv branch October 21, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbruijnshkv rbruijnshkv rbruijnshkv approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@visr @rbruijnshkv