Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Afbouwen vv wrij #166

Merged
merged 11 commits into from
Oct 17, 2024
Merged

Afbouwen vv wrij #166

merged 11 commits into from
Oct 17, 2024

Conversation

DanielTollenaar
Copy link
Collaborator

  • debug-script voor vv -> rekenend model
  • start met wrij (nog niet af)
  • alle gebieden: reviewscript voert modelfouten.gpkg uit

@visr
Copy link
Member

visr commented Oct 17, 2024

All these 00 scripts look identical except for the authority and short_name. Why not create a shared function and call it for a specific water authority? This leads to a lot of code duplication.

@DanielTollenaar
Copy link
Collaborator Author

All these 00 scripts look identical except for the authority and short_name. Why not create a shared function and call it for a specific water authority? This leads to a lot of code duplication.

Will do in next iteration, promise. For now not sure if we'll keep/drop/individually modify these scripts.

Copy link
Member

@visr visr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. Even if there are slight differences, it is probably possible to share the common parts.

@visr visr merged commit e0f021f into main Oct 17, 2024
4 checks passed
@visr visr deleted the afbouwen_vv_wrij branch October 17, 2024 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants