Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/621 extforce converter initial condition file #715

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

MAfarrag
Copy link

@MAfarrag MAfarrag commented Nov 15, 2024

Branched out of the feature/621_extforce_converter for the initial condition fille

arthurvd and others added 17 commits June 6, 2024 15:38
* basic program structure
* processing of a single [Meteo] block as first example code
* testcase c081 with multiple combined wind files.
…ties than only Meteo

See ConverterFactory and BaseConverter subclasses

ext_old_to_new is now a subdirectory, instead of a single script, to keep things organized.

BREAKING CHANGE: in hydrolib.core: renamed ExtOldFileType.Poyfile to ExtOldFileType.InsidePolygon
Makes serialized model files lean by only serializing the field values that have been explicitly set.
Only implemented for IniModel (and IniBasedModel).
On the longer term, can we get rid of `LegacyFMModel` (which only exists to support `[Model]` in MDU files), and have this backwards compatibility implemented in a less ad-hoc way?
Misc cleanup + new cmdline args:
* --postfix / -p : Append POSTFIX to the output filenames (before the extension).
* --[no]backup : Create a backup of each file that will be overwritten.
Copy link

sonarcloud bot commented Nov 15, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
5.1% Duplication on New Code (required ≤ 3%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants