-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent duplicate contacts/links in Link1d2d
#674
Merged
veenstrajelmer
merged 10 commits into
main
from
546-repeatedly-creating-1d2d-links-results-in-error-due-to-double-entries
Jul 8, 2024
Merged
Prevent duplicate contacts/links in Link1d2d
#674
veenstrajelmer
merged 10 commits into
main
from
546-repeatedly-creating-1d2d-links-results-in-error-due-to-double-entries
Jul 8, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
veenstrajelmer
changed the title
updated with suggestions of @KReef
Prevent duplicate contacts/links in Jul 5, 2024
Link1d2d
…-to-double-entries' of https://github.com/Deltares/HYDROLIB-core into 546-repeatedly-creating-1d2d-links-results-in-error-due-to-double-entries
Quality Gate passedIssues Measures |
8 tasks
priscavdsluis
approved these changes
Jul 8, 2024
veenstrajelmer
deleted the
546-repeatedly-creating-1d2d-links-results-in-error-due-to-double-entries
branch
July 8, 2024 09:06
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done:
Link1d2d._process()
with properties, just like forMesh2d
in Integrate MeshKernelPy >=3.0.0 #574Tests are all green, but somehow not automatically linked below in the conversation: https://github.com/Deltares/HYDROLIB-core/actions/runs/9810990362