Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent duplicate contacts/links in Link1d2d #674

Conversation

veenstrajelmer
Copy link
Collaborator

@veenstrajelmer veenstrajelmer commented Jul 5, 2024

Done:

Tests are all green, but somehow not automatically linked below in the conversation: https://github.com/Deltares/HYDROLIB-core/actions/runs/9810990362

@veenstrajelmer veenstrajelmer changed the title updated with suggestions of @KReef Prevent duplicate contacts/links in Link1d2d Jul 5, 2024
Copy link

sonarcloud bot commented Jul 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
1 Accepted issue

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@tim-vd-aardweg tim-vd-aardweg added this to the Release 1.0 milestone Jul 8, 2024
@veenstrajelmer veenstrajelmer merged commit e73aaac into main Jul 8, 2024
1 check passed
@veenstrajelmer veenstrajelmer deleted the 546-repeatedly-creating-1d2d-links-results-in-error-due-to-double-entries branch July 8, 2024 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Repeatedly creating 1D2D links results in error due to double entries
3 participants