Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build issues #127

Merged
merged 11 commits into from
Sep 4, 2024
Merged

Fix build issues #127

merged 11 commits into from
Sep 4, 2024

Conversation

dalmijn
Copy link
Collaborator

@dalmijn dalmijn commented Sep 2, 2024 •
edited
Loading

Issue addressed

Fixes #124

Explanation

Code

Checklist

  • Updated tests or added new tests
  • Branch is up to date with master
  • Tests & pre-commit hooks pass
  • Updated documentation if needed

Additional Notes (optional)

No.

@dalmijn
Copy link
Collaborator Author

dalmijn commented Sep 2, 2024

@Jaapel, Thanks for laying the groundwork. I copied some stuff out of your PR #126 and added it here. I made a separate PR as I really tried to uniformly understand what happened and how to solve it (e.g. with the env variables of gdal).

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Sep 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

Jaapel
Jaapel approved these changes Sep 3, 2024
View reviewed changes
.build/linux64.sh Outdated Show resolved Hide resolved
Jaapel
Jaapel approved these changes Sep 3, 2024
View reviewed changes
Copy link

@Jaapel Jaapel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, I will close mine.

.build/hook-fiat.py Outdated Show resolved Hide resolved
.build/linux64.sh Outdated Show resolved Hide resolved
Dockerfile Outdated Show resolved Hide resolved
@Jaapel Jaapel mentioned this pull request Sep 3, 2024
Closed
4 tasks
@dalmijn dalmijn requested a review from Jaapel September 4, 2024 08:33
@dalmijn dalmijn merged commit afdbc60 into master Sep 4, 2024
4 checks passed
@dalmijn dalmijn deleted the build branch September 10, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jaapel Jaapel Jaapel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken DriverNotFoundError calls in io.py
2 participants
@dalmijn @Jaapel