Revert "Revert "Revert AME buff"" #996
Merged
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit e271a5d.
|
I've already said before this isn't a good idea without the pending fixed from upstream, but I can't stop you |
We talked about it. We took into consideration what you said. Decided it's worth the risk/reward and we're prepared to undo it if it's too problematic. |
If it breaks, I told you so ¯\_(ツ)_/¯ |
|
is there any issue i havent seen any problem when not using 1 core ops |
VMSolidus
pushed a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
Apr 8, 2024
## Mirror of PR #996: [Revert "Revert "Revert AME buff""](DeltaV-Station/Delta-v#996) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-23 00:07:05 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/107660393?v=4" width="16"/><a href="https://github.com/IamVelcroboy"> IamVelcroboy</a> at 2024-03-23 00:16:26 UTC</aside> <sup> `b4fc2e342be6ef395b1ca21f27787ac08a89df59` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: C# --- <details open="true"><summary><h1>Original Body</h1></summary> > Reverts DeltaV-Station/Delta-v#939 > > We might revert this again if everything burns but it's worth a shot. Let's gooo > > > **Changelog** > 🆑 Velcroboy > - tweak: Reverted AME buff. AME will require more than 1 core again to function properly. </details> Co-authored-by: Velcroboy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #939
We might revert this again if everything burns but it's worth a shot. Let's gooo
Changelog
🆑 Velcroboy