Fix Moth not eating Jumpskirts #976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit f691377.
1 task
VMSolidus
pushed a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
Mar 18, 2024
<!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> <!-- The text between the arrows are comments - they will not be visible on your PR. --> ## About the PR <!-- What did you change in this PR? --> Ports: DeltaV-Station/Delta-v#976 Ports: DeltaV-Station/Delta-v#975 ## Technical details <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> "PrisonJumpsuit" component is removed from jumpskirts, so none of the tags are needed hence PrisonJumpskirt no longer needs to overwrite any tags. WhitelistChameleon, ClothMade and Skirt are added to fix Harpy, Cloth and Chameleon issues. ## ( I haven't tested the jumpskirts in the chameleon menu ) ## Media - [X] this PR does not require an ingame showcase ## Breaking changes <!-- List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. --> PrisonUniform no longer used on Jumpskirts **Changelog** :cl: DangerRevolution - fix: Fixed Harpies being unable to wear prison jumpskirts - fix: Moths can now eat jumpskirts - fix: Jumpskirts are now a chameleon option.
VMSolidus
pushed a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
Apr 8, 2024
## Mirror of PR #976: [Fix Moth not eating Jumpskirts](DeltaV-Station/Delta-v#976) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/142105406?v=4" width="16"/><a href="https://github.com/DangerRevolution"> DangerRevolution</a> at 2024-03-17 17:28:00 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/142105406?v=4" width="16"/><a href="https://github.com/DangerRevolution"> DangerRevolution</a> at 2024-03-17 17:45:11 UTC</aside> <sup> `0271f2ac35a433d06f761936e0d644c8a41f4548` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > <!-- What did you change in this PR? --> > > Moths can now eat jumpskirts by adding - clothmade tag > > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > > moths hungry > > > ## Media > > - [X] this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > :cl: DangerRevolution > - fix: Moths can now eat skirts > </details> Co-authored-by: Danger Revolution! <[email protected]>
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 3, 2025
# Description This PR makes it so that Glimmer Mites can only spawn on "The Main Station", as defined by GetSpawnableStations. Yes this is seemingly pretty hardcodey, but because on our codebase it's simply not possible for GetSpawnableStations to ever return anything other than a list with an index of 0, we can extremely reliably count on GetSpawnableStations()[0] to be "THE Station". This fixes an issue whereby Glimmer Mites can spawn in places where it is simply not possible for players to reach them. Such as random asteroids in space, CENTCOMM, Nukie World, or the Syndicate Listening Outpost. # Changelog :cl: - fix: Glimmer Mites can no longer spawn anywhere other than "THE" Station.
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Moths can now eat jumpskirts by adding - clothmade tag
Why / Balance
moths hungry
Media
Breaking changes
Changelog
🆑 DangerRevolution