Fix #974 #975
Merged
Fix #974 #975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
VMSolidus
pushed a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
Mar 18, 2024
<!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> <!-- The text between the arrows are comments - they will not be visible on your PR. --> ## About the PR <!-- What did you change in this PR? --> Ports: DeltaV-Station/Delta-v#976 Ports: DeltaV-Station/Delta-v#975 ## Technical details <!-- If this is a code change, summarize at high level how your new code works. This makes it easier to review. --> "PrisonJumpsuit" component is removed from jumpskirts, so none of the tags are needed hence PrisonJumpskirt no longer needs to overwrite any tags. WhitelistChameleon, ClothMade and Skirt are added to fix Harpy, Cloth and Chameleon issues. ## ( I haven't tested the jumpskirts in the chameleon menu ) ## Media - [X] this PR does not require an ingame showcase ## Breaking changes <!-- List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. --> PrisonUniform no longer used on Jumpskirts **Changelog** :cl: DangerRevolution - fix: Fixed Harpies being unable to wear prison jumpskirts - fix: Moths can now eat jumpskirts - fix: Jumpskirts are now a chameleon option.
VMSolidus
pushed a commit
to Simple-Station/Einstein-Engines
that referenced
this pull request
Apr 8, 2024
## Mirror of PR #975: [Fix #974](DeltaV-Station/Delta-v#975) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/142105406?v=4" width="16"/><a href="https://github.com/DangerRevolution"> DangerRevolution</a> at 2024-03-17 17:21:59 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/142105406?v=4" width="16"/><a href="https://github.com/DangerRevolution"> DangerRevolution</a> at 2024-03-17 17:31:11 UTC</aside> <sup> `e2d21fe8677a24f632a4729148814272b2a1c6a2` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > the title + it fixes #974 > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > it's not intended > > ## Media > > - [X] this PR does not require an ingame showcase > > > **Changelog** > 🆑 DangerRevolution > - fix: Harpies can now wear prison jumpskirt > > </details> Co-authored-by: Danger Revolution! <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
the title + it fixes #974
Why / Balance
it's not intended
Media
Changelog
🆑 DangerRevolution