-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
port lighthouse real #883
port lighthouse real #883
Conversation
@IamVelcroboy if you have any big concerns rn id like to hear them, before anything else is finalized |
No concerns until I get a chance to look it over. You'll also need to add it to the map pool located in the prototype folder and the postmapinittest before it's merged. Also if you could get a render that would be nice. If not, I'll try to get one tomorrow. |
ill try render it when im awake |
No rush. I'm off to bed soon too. I was told you are not on Discord, so, here is the list of changes we've made since the Rebase. It looks like you got most of them already. Just wanted you to have it if it helps.
(IMPORTANT-Rotation of cryobeds matters. Players emerge from direction rotated. So, don't send players into walls.)
|
I tried doing it, got |
Looks like there's a borked toy sword and the cargo console is still trying to link to the telepad. Easy to fix. Run the tidy tool if you can. Otherwise I can do it tomorrow. |
My discord isn't loading so I'm just gonna leave it here. I know it's a case of "you snooze, you lose" but @IamVelcroboy might be worth holding a little as last I checked, RK and ODJ are finishing up a compete remaster of Lighthouse. Might be worth comparing 1:1. RK did say they were burnt out recently and weren't working on it, but then came back to working on it?? TLDR: |
@OldDanceJacket are you finishing a port if so ill close and ill clean up the evil uids now |
RK was the main one working on it and I've asked them abt it, I'll let you know :O |
it has no bomb testing room but idk where to put it |
Assuming you mean space, it could be separate from sec proper like on Submarine. Could also not include it, it is an optional thing. |
some maps which don't have a dedicated room just stick it in the armoury and let Sec figure it out |
|
door naming ops i thought it was bad, will have to do a pass of naming everything |
Naming doors is fairly important for Lighthouse, players have cited it as a very good feature of the map that they did use. |
Not to you jacket, |
the top was used by tiders that break in and cook meth the engi minimed is used reasonably often when engi gets bombed or whatever (its also near epi and evac which are also more heavily injured than, laser tag) |
You've pissed off the networking gods, its over |
Just letting you know I didn't forget about this. Trying to find time to do a proper review. Should be soon™. |
|
pretty sure thats from before big light prune |
Just checking, did the commits above address the list of issues? Is it ready to be reviewed again? Or do you have more to do yet? |
everything should be done, besides warp point stuff |
Great! Here's how we are mapping our WPs now
I'll try to get the re-reviewed early next week and possibly added to the pool again. Thanks! |
So, I still think there are a few too many lights in some places but I'm going to merge anyway. Maybe I'll do a pass later when I have some time and adjust those spots. |
|
* port lighthouse and dosome work * fix evil things * add to pool and test * most of the logi rework, replace viro with some cryo beds * more reworks * fixes * updatey * more fix * techie spawn and more suit storage * actually add the techie spawns * name every door * gaming * mostly fix/add cameras * warp point gaming --------- Co-authored-by: deltanedas <@deltanedas:kde.org>
## Mirror of PR #883: [port lighthouse real](DeltaV-Station/Delta-v#883) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) <aside>PR opened by <img src="https://avatars.githubusercontent.com/u/39013340?v=4" width="16"/><a href="https://github.com/deltanedas"> deltanedas</a> at 2024-02-22 02:45:04 UTC</aside> <aside>PR merged by <img src="https://avatars.githubusercontent.com/u/39013340?v=4" width="16"/><a href="https://github.com/deltanedas"> deltanedas</a> at 2024-04-06 23:38:40 UTC</aside> <sup> `37c0bc87956767359471b3ba159f9d8aa89a3256` </sup> --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Status: Needs Review - Changes: Map - Changes: C# --- <details open="true"><summary><h1>Original Body</h1></summary> > ## About the PR > bring lighthouse back with some major changes: > - redid all of epi > - replaced meme ai room with an actual theatre for doing plays real > - logi reworked, cargo shuttle and not telepad!!!! > - bringing it up to speed in most places its old > - cryooooo > - ai core with airlocks and disposals entrance > - atmos has teg > - armoury has mines so its not completely piss easy to break into it > - replaced broadway med outpost with psychologist office > - random stuff > > still needs more test > > # Media > station map > ![17:59:40](https://github.com/DeltaV-Station/Delta-v/assets/39013340/f566707e-6e83-4843-9f75-2d59b8becc28) > > > render > ![Lighthouse-0](https://github.com/DeltaV-Station/Delta-v/assets/39013340/68c46f45-d68c-4973-b63b-169499293f18) > > **Changelog** > 🆑 > - add: Lighthouse is BACK! > </details> Co-authored-by: deltanedas <[email protected]> Co-authored-by: VMSolidus <[email protected]>
About the PR
bring lighthouse back with some major changes:
still needs more test
Media
station map
render
Changelog
🆑