Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates shoukou up to date. #863

Closed
wants to merge 1 commit into from

Conversation

Adrian16199
Copy link
Contributor

@Adrian16199 Adrian16199 commented Feb 19, 2024

About the PR

Updates shoukou:
Redid captain's quarters to provide more space for the captain's antique laser's gun display.
Replaced cloning with metem cloning.

Most importantly, fixes that one light in the substation's room behind medical to not be on the door.

Why / Balance

Because wizden merge.

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

Redid captain's quarters to provide more space for the captain's antique laser's gun display.
Replaced cloning with metem cloning.
@deltav-mapserver
Copy link

deltav-mapserver bot commented Feb 19, 2024

This PR contains new or changed maps:

Shoukou

image

02/19/24 17:56

@IamVelcroboy
Copy link
Member

This doesn't look like you pulled from the map directory, which would include the changes from this

@Adrian16199
Copy link
Contributor Author

Well thats just lovely then because I updated the master before doin mappin.

@Adrian16199
Copy link
Contributor Author

I could attempt again, just a flex that it just didnt though that it wouldnt update the map.

@IamVelcroboy
Copy link
Member

When you load a map in mapping it loads from the bin/data folder not the resources/maps (unless you direct it to do so specifically.) So, if changes were made on the map since last time you updated, you need to move the map from resources/maps over to bin/data. (or do like mapping ## /resources/maps/map.yml)

@Adrian16199
Copy link
Contributor Author

That just makes me think that many updates were neglected because i didnt though of that. Buh

@Adrian16199 Adrian16199 marked this pull request as draft February 19, 2024 21:37
@IamVelcroboy
Copy link
Member

The only other edits I can see that I made were adding the vault freezer and spare ID cabinet. As long as you still have those somewhere, should be good. Just duplicate the changes you made on the file after the light overhaul I did last week and should be ok.

@Adrian16199
Copy link
Contributor Author

I know that the ID cabinet is DEFINITELY there since I had to give a biscuit to it once, Freezer is still somethin I dont understand when it comes to its existance but its probably there aswell.
Will probably redo this tomorow tho.

@IamVelcroboy
Copy link
Member

Ok, no problem. Sorry for the confusion.

@Adrian16199
Copy link
Contributor Author

Need to redo it.

@Adrian16199 Adrian16199 deleted the shoukou-metem branch February 20, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants