Makes mail teleporter craftable. #832
Conversation
Makes a mail teleporter craftable and only provides the board to the LO's locker. The point of this PR is to allow courier's to perhaps still be able to keep goin, even if the mail teleporter that was mapped was nuked/destroyed/vanished. To-do: Figure out why it gives an error and not make it when you do all steps and screwdriver it.
Resources/Prototypes/Nyanotrasen/Entities/Structures/Machines/mailTeleporter.yml
Show resolved
Hide resolved
Resources/Prototypes/Nyanotrasen/Entities/Objects/Devices/CircuitBoards/production.yml
Outdated
Show resolved
Hide resolved
|
Uh, if its not what I have given then that makes it very confusing but I will attempt to understand. It does work as it should currently in the build but if its neccesary. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: Adrian16199 <[email protected]>
I do believe the issue that was given was resolved because I was a dummy and simply didnt inherited the buildable parent like deltanedas suggested which would have saved me so much time. |
Yep, I saw the change |
|
Imma merge this as the existence of the boards doesn't really affect anything. We can figure out what to do with it from there. Likely map it into board vaults/CE office. |
Does the teleporter queue respect the fact there can be multiple mail teleporters? Has this been tested to make sure it wont spawn the same mail twice? |
As it currently stands, the only board that exists is if either someone maps it (Maybe could have puted a DO NOT MAP on it) or you disassemble the mail teleporter itself. |
It spawns double the mail from memory. We discussed this on Discord and so this will be put in the board vault & CE room to try negate whatever mailmaxxing Logistics gets up to. Still an issue though. |
|
I don't think this should've been merged if it could allow for mail duplication |
|
Im fine with it being unmerged if its neccesary. |
It can't do anything on its own. These are only accessible if we make them accessible. That's what we were considering from here. |
Ah, my mistake. All good then |
|
it should be fixed to pick a random/alternating teleporter when multiple exist before mapping boards. cargo WILL use this to get double mail otherwise |
* Makes mail teleporter craftable. Makes a mail teleporter craftable and only provides the board to the LO's locker. The point of this PR is to allow courier's to perhaps still be able to keep goin, even if the mail teleporter that was mapped was nuked/destroyed/vanished. To-do: Figure out why it gives an error and not make it when you do all steps and screwdriver it. * makes it craftable. * Makes it work * Update mailTeleporter.yml * Update heads.yml --------- Signed-off-by: Adrian16199 <[email protected]> Co-authored-by: Velcroboy <[email protected]>
## Mirror of PR #832: [Makes mail teleporter craftable.](DeltaV-Station/Delta-v#832) from <img src="https://avatars.githubusercontent.com/u/131613340?v=4" alt="DeltaV-Station" width="22"/> [DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v) PR opened by <img src="https://avatars.githubusercontent.com/u/144424013?v=4" width="16"/><a href="https://github.com/Adrian16199"> Adrian16199</a> at 2024-02-13 22:23:11 UTC PR merged by <img src="https://avatars.githubusercontent.com/u/144424013?v=4" width="16"/><a href="https://github.com/Adrian16199"> Adrian16199</a> at 2024-03-28 21:56:14 UTC `f6714a5927587430b9a7da0e507029825966e159` --- PR changed 0 files with 0 additions and 0 deletions. The PR had the following labels: - Changes: YML - Status: Needs Review --- <details open="true"><summary><h1>Original Body</h1></summary> > To-do > - [X] Figure out why it gives an error and not make it when you do all steps and screwdriver it. > - [X] Figure out how to make it drop the board upon being deconstructed since currently it doesnt drop ANYTHING. > > <!-- Please read these guidelines before opening your PR: https://docs.spacestation14.io/en/getting-started/pr-guideline --> > <!-- The text between the arrows are comments - they will not be visible on your PR. --> > > ## About the PR > <!-- What did you change in this PR? --> > Makes a mail teleporter craftable and only provides the board to the LO's locker. > ## Why / Balance > <!-- Why was it changed? Link any discussions or issues here. Please discuss how this would affect game balance. --> > The point of this PR is to allow courier's to perhaps still be able to keep goin, even if the mail teleporter that was mapped was nuked/destroyed/vanished. > > ## Media > <!-- > PRs which make ingame changes (adding clothing, items, new features, etc) are required to have media attached that showcase the changes. > Small fixes/refactors are exempt. > Any media may be used in SS14 progress reports, with clear credit given. > > If you're unsure whether your PR will require media, ask a maintainer. > > Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]): > --> > > - [ ] I have added screenshots/videos to this PR showcasing its changes ingame, **or** this PR does not require an ingame showcase > > ## Breaking changes > <!-- > List any breaking changes, including namespace, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be pasted in #codebase-changes. > --> > > **Changelog** > <!-- > Make players aware of new features and changes that could affect how they play the game by adding a Changelog entry. Please read the Changelog guidelines located at: https://docs.spacestation14.io/en/getting-started/pr-guideline#changelog > --> > > <!-- > Make sure to take this Changelog template out of the comment block in order for it to show up. > 🆑 > - add: Added fun! > - remove: Removed fun! > - tweak: Changed fun! > - fix: Fixed fun! > --> > </details> Co-authored-by: Adrian16199 <[email protected]> Co-authored-by: VMSolidus <[email protected]>
To-do
About the PR
Makes a mail teleporter craftable and only provides the board to the LO's locker.
Why / Balance
The point of this PR is to allow courier's to perhaps still be able to keep goin, even if the mail teleporter that was mapped was nuked/destroyed/vanished.
Media
Breaking changes
Changelog