Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back paradox anomaly #825

Merged
merged 9 commits into from
Feb 13, 2024
Merged

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Feb 12, 2024

About the PR

title

Why / Balance

terminator 3 judgement weekend we do a lot of judging

Technical details

its terminator under the hood all the unique code is spawning

key differences from legacy:

  • it wont select any antag since it doesnt copy uplink and stuff, you cant easily steal implants, "oh you are antag? name every antag component in 1 file" :trollface:
  • instead of just kill + escape objectives, you also have an obj to keep your target alive. there is no more greentext so the choice to be friends isnt "punished"

spawning is still mostly copypaste shitcode so big warning slapped over it (im amazed it still works)

Media

ghost role is real
081959

valid
091557

redtext is real
091613

cloning a paradox anomaly just works how
092847

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

no

Changelog
🆑

  • add: Brought back paradox anomalies. Beware anyone that looks just like you!

@github-actions github-actions bot added Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Feb 12, 2024
Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If its getting reimplemented anyways, all mentions of "Evil Twin" in the code should be replaced with "Paradox Anomaly"

Resources/Prototypes/DeltaV/Objectives/eviltwin.yml Outdated Show resolved Hide resolved
@deltanedas
Copy link
Member Author

why does the pr have warning thing for merging master it shouldnt have any effect on merging right

@deltanedas deltanedas marked this pull request as ready for review February 13, 2024 09:29
@deltanedas deltanedas requested a review from DebugOk February 13, 2024 09:29
@DebugOk
Copy link
Contributor

DebugOk commented Feb 13, 2024

why does the pr have warning thing for merging master it shouldnt have any effect on merging right

It just does that sometimes, it really doesn't matter for merging

@Bonktrauma
Copy link
Contributor

Vm solidus already has a working version, they are just waiting for metem to be merged

@DangerRevolution
Copy link
Contributor

DangerRevolution commented Feb 13, 2024

Vm solidus already has a working version, they are just waiting for metem to be merged

This is kinda irrelevant and kinda rude; when Metem is merged the two versions can be compared and things can be improved if and where necessary.

@Bonktrauma
Copy link
Contributor

Bonktrauma commented Feb 13, 2024

Vm solidus already has a working version, they are just waiting for metem to be merged

This is kinda irrelevant and kinda rude; when Metem is merged things can be compared and things can be improved if and where necessary.

Sorry, just wanted to inform them somebody had already worked on it, I didn't mean to seem rude, anyways this is cool, can't wait to see it merged

@DebugOk
Copy link
Contributor

DebugOk commented Feb 13, 2024

Vm solidus already has a working version, they are just waiting for metem to be merged

I much prefer the implementation proposed here over the original nyano era implementation

@Bonktrauma
Copy link
Contributor

Vm solidus already has a working version, they are just waiting for metem to be merged

I much prefer the implementation proposed here over the original nyano era implementation

This one is also more complete and ready

@DebugOk DebugOk merged commit 9985ee9 into DeltaV-Station:master Feb 13, 2024
20 checks passed
DeltaV-Bot pushed a commit that referenced this pull request Feb 13, 2024
@deltanedas deltanedas deleted the paradox-ops branch February 13, 2024 16:16
@VMSolidus
Copy link
Contributor

@deltanedas Hey so, I have a follow-up question to this PR, after spending a little bit of time thinking about it, and also editing the wiki to reflect the new "Kill OR Save your target" mechanic. What if we were to add a system that checks if the person being paradox cloned was a traitor, and then selectively give the paradox anomaly objectives that were intended to be directly opposed to them?

Such as for example. John Smith(Real), is a traitor with an objective to kill the Captain. If a Paradox Anomaly rolled him as its clone, it would then generate objectives diametrically opposed wherever possible. So a Kill Captain objective becomes Protect Captain. Steal objectives can remain(Only one person can steal the captain's spare ID!), etc.

@DebugOk
Copy link
Contributor

DebugOk commented Feb 13, 2024

@deltanedas Hey so, I have a follow-up question to this PR, after spending a little bit of time thinking about it, and also editing the wiki to reflect the new "Kill OR Save your target" mechanic. What if we were to add a system that checks if the person being paradox cloned was a traitor, and then selectively give the paradox anomaly objectives that were intended to be directly opposed to them?

I don't like that

@deltanedas
Copy link
Member Author

traitors are antags so arent eligible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants