Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify antagAdvantage values. #804

Closed
wants to merge 8 commits into from
Closed

Modify antagAdvantage values. #804

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3cb7749
Modify antagAdvantage values.
stellar-novas Feb 9, 2024
31829f5
Add antagAdvantage to chemist and modify other role's values.
stellar-novas Feb 9, 2024
3eaf693
Add antagAdvantage for mail carrier
stellar-novas Mar 26, 2024
9b342cd
Remove mantis antagAdvantage
stellar-novas Mar 26, 2024
987b580
When the typo
stellar-novas Mar 26, 2024
8fb63a2
Update Resources/Prototypes/Nyanotrasen/Roles/Jobs/Epistemics/forensi…
stellar-novas Mar 26, 2024
526e8c6
Merge branch 'master' into advantage-changes
stellar-novas Mar 27, 2024
500a403
I hate GitHub sometimes...
stellar-novas Mar 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Resources/Prototypes/Nyanotrasen/Roles/Jobs/Cargo/mail_carrier.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
name: job-name-mail-carrier
description: job-description-mail-carrier
startingGear: CourierGear
antagAdvantage: 2 # Delta-V - Reduced TC: Changed to match cargo tech
playTimeTracker: JobMailCarrier
icon: "JobIconMailCarrier"
supervisors: job-supervisors-qm
Expand Down
2 changes: 1 addition & 1 deletion Resources/Prototypes/Nyanotrasen/Roles/Jobs/Epistemics/forensicmantis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
startingGear: ForensicMantisGear
icon: "JobIconForensicMantis"
supervisors: job-supervisors-rd
antagAdvantage: 5 # DeltaV - From 4 to 5
#antagAdvantage: # DeltaV - Removes AntagAdvantage
canBeAntag: true # DeltaV - Mantis is no longer a Detective
# whitelistRequired: true
access:
Expand Down
2 changes: 1 addition & 1 deletion Resources/Prototypes/Roles/Jobs/Cargo/cargo_technician.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name: job-name-cargotech
description: job-description-cargotech
playTimeTracker: JobCargoTechnician
antagAdvantage: 2 # DeltaV - Reduced TC: External Access
antagAdvantage: 2 # DeltaV - Reduced TC: Cargo Access
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How is Cargo Access beneficial? I see it on lowpop maybe, otherwise I don't get the advantage in having Cargo Access.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah cargo techs cant buy things alone anymore (outside of lowpop ofc)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgor to reduce the cargo advantage

The argument was because they could smuggle stuff out semi-easily, I removed it all together in a first draft

startingGear: CargoTechGear
icon: "JobIconCargoTechnician"
supervisors: job-supervisors-qm
Expand Down
2 changes: 1 addition & 1 deletion Resources/Prototypes/Roles/Jobs/Cargo/salvage_specialist.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name: job-name-salvagespec
description: job-description-salvagespec
playTimeTracker: JobSalvageSpecialist
antagAdvantage: 3 # DeltaV - Reduced TC: External Access + Free hardsuit and weapons
antagAdvantage: 3 # DeltaV - Reduced TC: Free hardsuit and weapons
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weapons?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Salv weapons + wreck loot + potential of getting weapons from logi though that doesn't happen much now

requirements:
- !type:DepartmentTimeRequirement
department: Logistics # DeltaV - Logistics Department replacing Cargo
Expand Down
1 change: 0 additions & 1 deletion Resources/Prototypes/Roles/Jobs/Civilian/service_worker.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@
icon: "JobIconServiceWorker"
supervisors: job-supervisors-service
canBeAntag: true # DeltaV - Can be antagonist
antagAdvantage: 1 # DeltaV - Reduced TC: Accesses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#antagAdvantage: 1 # DeltaV - Removes antagAdvantage

Not our prototype, we shouldn't be removing lines :O

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh yea, I will fix this when I'm home

access:
- Service
- Maintenance
Expand Down
4 changes: 2 additions & 2 deletions Resources/Prototypes/Roles/Jobs/Engineering/atmospheric_technician.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name: job-name-atmostech
description: job-description-atmostech
playTimeTracker: JobAtmosphericTechnician
antagAdvantage: 10 # DeltaV - Reduced TC: External Access + Fireaxe + Free Hardsuit
antagAdvantage: 2 # DeltaV - Reduced TC: Free Firesuit + Engineering + Atmospherics
requirements:
- !type:DepartmentTimeRequirement
department: Engineering
Expand All @@ -29,4 +29,4 @@
ears: ClothingHeadsetEngineering
innerClothingSkirt: ClothingUniformJumpskirtAtmos
satchel: ClothingBackpackSatchelAtmosphericsFilled
duffelbag: ClothingBackpackDuffelAtmosphericsFilled
duffelbag: ClothingBackpackDuffelAtmosphericsFilled
2 changes: 1 addition & 1 deletion Resources/Prototypes/Roles/Jobs/Engineering/station_engineer.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name: job-name-engineer
description: job-description-engineer
playTimeTracker: JobStationEngineer
antagAdvantage: 3 # DeltaV - Reduced TC: External Access + Engineering
antagAdvantage: 1 # DeltaV - Reduced TC: Engineering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is Engineering Access an advantage, and why is it less of an advantage than Cargo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy access to tools and insuls, this one was very contentious, as people thought it mattered more/less.
Also easy sabotage of engineering systems, like comms on the maps that they're in engi, as well as power.

And cargo was meant to match engi, I forgor as I said

requirements:
- !type:DepartmentTimeRequirement
department: Engineering
Expand Down
2 changes: 1 addition & 1 deletion Resources/Prototypes/Roles/Jobs/Engineering/technical_assistant.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name: job-name-technical-assistant
description: job-description-technical-assistant
playTimeTracker: JobTechnicalAssistant
antagAdvantage: 3 # DeltaV - Reduced TC: External Access + Engineering
antagAdvantage: 1 # DeltaV - Reduced TC: Engineering
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refer to the point about Engineers + new players being given less TC

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same thing, and why give the noob roles less TC? They have the same access

requirements:
- !type:OverallPlaytimeRequirement # DeltaV - to prevent griefers from taking the role.
time: 14400 # 4 hours
Expand Down
1 change: 1 addition & 0 deletions Resources/Prototypes/Roles/Jobs/Medical/chemist.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
startingGear: ChemistGear
icon: "JobIconChemist"
supervisors: job-supervisors-cmo
antagAdvantage: 2 # DeltaV - Reduced TC: Chemistry access
stellar-novas marked this conversation as resolved.
Show resolved Hide resolved
access:
- Medical
- Chemistry
Expand Down
2 changes: 1 addition & 1 deletion Resources/Prototypes/Roles/Jobs/Medical/paramedic.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
name: job-name-paramedic
description: job-description-paramedic
playTimeTracker: JobParamedic
antagAdvantage: 2 # DeltaV - Reduced TC: External Access
antagAdvantage: 1 # DeltaV - Reduced TC: Handheld crew monitor
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Magic track anyone device on your person from shift start is good, consensus was it was worth an advantage of 1.

requirements:
# - !type:RoleTimeRequirement # DeltaV - No Medical Doctor time requirement
# role: JobMedicalDoctor
Expand Down
Loading