Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test #738

Conversation

DangerRevolution
Copy link
Contributor

About the PR

Why / Balance

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

Neptune-Zvezda and others added 30 commits December 20, 2023 01:09
This is suffering
Should be all working but fact check it
Moved Items to Delta V Directory as well as condensing into singular Yml files
removed all _ from names of files and reading
Moved all Department Themed Socks to respective __-drobes Certain socks to Department Head Lockers
Last todo's Fix Image Sizes ( to be done)
add standard socks to certain random spawn pools
For real fixed the icons this time however test enviroment server was acting extremely unstable with ajustment of the Yml's from \ Backslashes to / forward slashes to match existing file formating
Removed " " from Json's around coder socks as could have been causing issues as well as syncing inventory with master due to new winter boot addions
Adjusted Json to follow Requested Copyright More Closely
Refixed Pride Vendor stock as seemed to have forgotten to save changes in the past,
Renamed the Logi Socks to not include a - to avoid errors
Renamed Atmos Socks to have correct spelling of engineering on Files and yml
Remembered to Add the Qm's Socks to Locker
i forgot to add DeltaV to parka sprite code
Thank you colin!

Co-authored-by: Colin-Tel <[email protected]>
Signed-off-by: Neptune <[email protected]>
im fixing the Names of "Equip-FEET" to not be capitialized
Updated N parka to move sleeves one pixel in as well as fixing a stray pixel on the front view
Adjusted all Item Id to include ClothingUnder as to standardise for researching,
Socks Should now be eatable by moffs
N parka now has storage
Fixed ID Name in Medidrobe as was not updated with ClothingUnder like other drobes
Patched N parka and atmos socks to have correct Id in Yml's to match other items
Neptune-Zvezda and others added 18 commits December 27, 2023 13:50
Updated N parka Names to not Include _'s to standardize naming
Changed Sock .Yml EngineeringAtmos to be / and not \  (got to read update with rename of folder)
Finally Noticed Socks was in the Id Name for Atmos Socks Twice
Captain's locker was too filed to fit the socks, moved to pride vendor until futher ideas
Socks Moved From captain locker were not given a amount to be stocked with.
Adjusted Cost of pride restock as with addion of "captain" socks went over the cost limit
@github-actions github-actions bot added S: Merge Conflict Fix your PR! Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Jan 30, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Copy link
Contributor

github-actions bot commented Jan 30, 2024

RSI Diff Bot; head commit b388b99 merging into fa88a26
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Under/Socks/coder.rsi

State Old New Status
equipped-FEET Modified
icon Modified

Resources/Textures/DeltaV/Clothing/OuterClothing/WinterCoats/NParka.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCaptainBlueandGold.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCaptainBlueandWhite.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCaptainGoldandBlue.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCargo.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCargoQm.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedEngineering.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedEngineeringAtmos.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedScience.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedSecurity.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedSecurityJackboots.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandGreen.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandLightBlue.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandLightBlueBunnySlipper.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandOrange.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandPurple.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandRed.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandYellow.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedYellowandPurple.rsi

State Old New Status
equipped-FEET Added
icon Added

Edit: diff updated after b388b99

@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants