Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More Borg Lawsets #706

Merged
merged 41 commits into from
Mar 7, 2024
Merged

More Borg Lawsets #706

merged 41 commits into from
Mar 7, 2024

Conversation

DangerRevolution
Copy link
Contributor

@DangerRevolution DangerRevolution commented Jan 21, 2024 •
edited
Loading

About the PR

  • Added several new lawsets to the Ion Storm pool
  • Janitor Borg now naturally has a Janitorial Lawset
  • Engineering Borg now naturally has an Engineering Lawset
  • Medical Borg now naturally has a Medical Lawset
  • Adds Potentially Harmful Lawsets to the Ion Storm pool

Why / Balance

Station 13 has some cool lawsets + extra variety is always good.

Also, more lawsets = more opportunities for varied RP + adding borgs their own lawsets is good; i.e doctor one

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

image

image

image

Changelog
🆑 DangerRevolution

  • add: Added several new potential Lawsets for Cyborgs.
  • tweak: Janitor/Engineer/Medical Borgs spawn with their own lawsets.

@github-actions github-actions bot added Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Jan 21, 2024
@DangerRevolution DangerRevolution marked this pull request as ready for review January 22, 2024 12:39
@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 28, 2024
@DangerRevolution
Copy link
Contributor Author

Moved things out into DeltaV folders & files + cleaned up & added comments where appropriate

DebugOk
DebugOk previously approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to ask someone else to read over this too, but as far as I'm concerned its good enough

@DangerRevolution DangerRevolution marked this pull request as draft February 13, 2024 11:58
@DangerRevolution
Copy link
Contributor Author

Just needs a few minor additions for the new "obeysTo" fields. Will do later, hopefully.

@DangerRevolution
Copy link
Contributor Author

Added "obeysTO" fields as per: space-wizards/space-station-14#24870

thanks Zap527 for explaining it, ObeysTo is just an add-on for future borg laws

image

i.e the "obeysTo" for corporate lawset is "station personnel" so this is added on to emag laws as shown above, instead of just mentioning "syndicate agents"

@DangerRevolution DangerRevolution marked this pull request as ready for review February 14, 2024 18:57
@DebugOk DebugOk mentioned this pull request Feb 26, 2024
Closed
@DebugOk DebugOk merged commit d504834 into DeltaV-Station:master Mar 7, 2024
10 checks passed
DeltaV-Bot pushed a commit that referenced this pull request Mar 7, 2024
Automatic Changelog Update (#706)
f767c45
@Tryded Tryded mentioned this pull request Oct 14, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deltanedas deltanedas deltanedas left review comments

@VMSolidus VMSolidus VMSolidus approved these changes

@DebugOk DebugOk Awaiting requested review from DebugOk

Assignees
No one assigned
Labels
Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@DangerRevolution @deltanedas @VMSolidus @DebugOk