Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanabō Fix #658

Closed
wants to merge 14 commits into from
Closed

Kanabō Fix #658

wants to merge 14 commits into from

Conversation

ps3moira
Copy link
Contributor

@ps3moira ps3moira commented Jan 9, 2024

About the PR

Updated the damage type for structural to match with the new structural re-work from upstream. I also fixed the Kanabō's stamina damage it's supposed to deal when wielded, as that was an oversight during rebase and wouldn't do so, but would if unwielded.

Why / Balance

Fixes the Kanabo's not properly giving out stamina and structural damage.

Media

  • this PR does not require an ingame showcase

Changelog
🆑

  • add: Added proper structural damage.
  • fix: Fixed Kanabō not giving stamina damage when wielded.

@ps3moira ps3moira requested a review from DebugOk as a code owner January 9, 2024 20:47
@github-actions github-actions bot added S: Needs Review Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Jan 9, 2024
Copy link
Contributor

github-actions bot commented Jan 9, 2024

RSI Diff Bot; head commit a9149c1 merging into 10a1433
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Nyanotrasen/Objects/Weapons/Melee/kanabou.rsi

State Old New Status
equipped-BACKPACK Modified

Edit: diff updated after a9149c1

@ps3moira
Copy link
Contributor Author

ps3moira commented Jan 9, 2024

This PR was part of #607 but separated it, due to it not being relevant to that PR.

@ps3moira ps3moira marked this pull request as draft January 9, 2024 21:00
@deltanedas
Copy link
Member

kanabou op once more :trollface:

@DebugOk
Copy link
Contributor

DebugOk commented Feb 12, 2024

Closing as stale alongside #607

@DebugOk DebugOk closed this Feb 12, 2024
@DebugOk DebugOk added the S: Derelict Has not been active for a while label Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Localization Changes any ftl files Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Derelict Has not been active for a while S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants