Hopefully fix atmos issues #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clamping is needed because x - x can be negative with floating point numbers. If we don't clamp here, the caller always has to call GetMoles(), clamp, then SetMoles(), which makes this function not very useful.
* Add Tmax * Increase Tmax
This reverts commit 054321d. Co-authored-by: Kevin Zheng <[email protected]>
github-actions
bot
added
S: Needs Review
Changes: C#
DeltaV-Bot
pushed a commit
that referenced
this pull request
Jan 7, 2024
DebugOk
added a commit
to DebugOk/Delta-v
that referenced
this pull request
Jan 20, 2024
* Check for divide by near zero (#22876) * Clamp after AdjustMoles() (#22907) Clamping is needed because x - x can be negative with floating point numbers. If we don't clamp here, the caller always has to call GetMoles(), clamp, then SetMoles(), which makes this function not very useful. * Add maximum atmos temperature limit (#22882) * Add Tmax * Increase Tmax * Revert "Add YAML gas reactions (#22803)" (#22939) This reverts commit 054321d. Co-authored-by: Kevin Zheng <[email protected]> --------- Co-authored-by: Kevin Zheng <[email protected]> Co-authored-by: Kara <[email protected]> (cherry picked from commit 6afde59)
DebugOk
pushed a commit
to DebugOk/Delta-v
that referenced
this pull request
Jan 20, 2024
(cherry picked from commit 10a1433)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to do a full merge, but its over 500 commits and I'm really not feeling good enough to do that right now. I know it'll be more by the next time I'll have time for it, but this at least gets the critical issue fixed sooner
Changelog
🆑