Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase nuclear operative playtime requirements. #655

Closed
wants to merge 1 commit into from

Conversation

BramvanZijp
Copy link
Contributor

About the PR

Here are the changes made to nukie requirements in this PR.

Nuclear Operative:
General Playtime: 30h > 30h
Security Playtime: 10h > 15h
Whitelist Needed: No > No

Nuclear Operative Agent:
General Playtime: 30h > 45h
Security Playtime: 0h > 10h
Medical Playtime: 10h > 15h
Whitelist Needed: No > Yes

Nuclear Operative Commander:
General Playtime: 60h > 60h
Security Playtime: 10h > 30h
Medical Playtime: 0h > 10h
Command Playtime: 10h > 15h
Whitelist Needed: Yes > Yes

Why / Balance

Some tweaks were done to need a few more hours for commander and regular nukie, but over all these are solid as is.
However the main issue in my opinion is the nuclear operative agent/medic. Too many people simply turn it on because "More chance for me to play nukie" but when they actually get it, completely neglect their responsibility to play the teams healer and prepare meds for that task, sometimes even asking others to take over the role, hardsuit, and hypospray entirely. As such, I gave its requirements a drastic boost, including needing a whitelist to play, in the hope that those with a whitelist are smart enough to turn off nukie medic if they don't want to play as the nukies MEDIC, or do not know enough to do so.

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • tweak: Cybersun has raised the requirements for those attempting to sign up for the elite division of Syndicate Nuclear Operatives, especially for agents/medics.

@DangerRevolution
Copy link
Contributor

As such, I gave its requirements a drastic boost, including needing a whitelist to play, in the hope that those with a whitelist are smart enough to turn off nukie medic if they don't want to play as the nukies MEDIC, or do not know enough to do so.

kind of +1 for the PR but generally I think; there should be some higher hour requirements to give us better Nukies and Nukies more likely used to roleplay under pressure

@deltanedas
Copy link
Member

ftr adding whitelist to a role people already have opted into wont do anything. no idea how to fix it

commander should need op experience not med

@Adrian16199
Copy link
Contributor

The whitelist on nuke med is probably not neccesary, if people dont want to play medic while still opt-in for it, that should just be ahelped.
Commander needing medical experience wouldnt hurt technicly since captain requires medical himself since he is suppose to watch over the crew so commander having to watch over his crew and one of em, needing medical experience, seems like a fair thing.

@DangerRevolution
Copy link
Contributor

DangerRevolution commented Jan 7, 2024

ftr adding whitelist to a role people already have opted into wont do anything. no idea how to fix it

commander should need op experience not med

oh also this by the way; Commander whitelist doesn't work at all, i've seen non-whitelisted staff get it all the time

I missed the Medic whitelist; don't whitelist Medic.

@Adrian16199
Copy link
Contributor

ftr adding whitelist to a role people already have opted into wont do anything. no idea how to fix it
commander should need op experience not med

oh also this by the way; Commander whitelist doesn't work at all, i've seen non-whitelisted staff get it all the time

Sadly there is nothing we can do (plays sad music), it only stops new people gettin into it which is better than nothin but the issue is still there..

@misandrie
Copy link
Contributor

The whitelist on nuke med is probably not neccesary, if people dont want to play medic while still opt-in for it, that should just be ahelped.

You can be queued into medic even if you have not opted in if noone had at all.

@DebugOk
Copy link
Contributor

DebugOk commented Jan 12, 2024

ftr adding whitelist to a role people already have opted into wont do anything. no idea how to fix it
commander should need op experience not med

oh also this by the way; Commander whitelist doesn't work at all, i've seen non-whitelisted staff get it all the time

Sadly there is nothing we can do (plays sad music), it only stops new people gettin into it which is better than nothin but the issue is still there..

There is and the code exists for jobs. It's just not applied to a tags iirc

@deltanedas
Copy link
Member

the code exists but if the database says you are opted in to an antag and an update adds a whitelist condition you dont meet, it doesnt update the database entry to force opt out

@DebugOk
Copy link
Contributor

DebugOk commented Jan 13, 2024

the code exists but if the database says you are opted in to an antag and an update adds a whitelist condition you dont meet, it doesnt update the database entry to force opt out

Code for disabling jobs you're opted into works fine. I just never made it work for roles iirc

@BramvanZijp
Copy link
Contributor Author

the code exists but if the database says you are opted in to an antag and an update adds a whitelist condition you dont meet, it doesnt update the database entry to force opt out

Code for disabling jobs you're opted into works fine. I just never made it work for roles iirc

Wouldnt it be possible to adapt that code to function for this too? Regardless if this is closed or merged it would be usefull.

@deltanedas
Copy link
Member

yes and yes

@DebugOk DebugOk closed this Feb 1, 2024
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants