Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shoukou maintenance update. #651

Closed
wants to merge 8 commits into from

Conversation

Adrian16199
Copy link
Contributor

@Adrian16199 Adrian16199 commented Jan 4, 2024

Also yes, I would like someone to review the map while im doin the finishing touches as it changes quite a bit.
Maintenance expanded in security (Yes, i did move the entire prison[pain]) and logistics
Powercell recharger in robotics
Redid piping in logistics.
Shuttle timer in both evac and arrivals
Removed laika
Fixed logistic's intercom being wrong way.
Redid wiring in security to go thro new maintenance.
EVA has been added to evacuation
Evacuation pod has been moved bit to the right.
Moved slimy to engineering instead of CE's office
Moved Shiva to security to proudly guard the HoS's office.
Upper solar's became a bit more broken
Added janitorial service lights

engineering
security
medical
Epistemics

Filling cabinet for detective
Janitorial service lights
Changes disposal pipe in bar to go different way
Changes piping
Man im tired.

About the PR

Security/logistic's maintenance with bit of other stuff.

Why / Balance

Because pain and misery, also people not tellin mappers whats the problem with the map but still talk about it publicly.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
    image
    image

Breaking changes

Changelog

Make sure to take this Changelog template out of the comment block in order for it to show up.
🆑

  • tweak: Changed shoukou, you will see bigger maintenance in logistics and security.

God this was just pain of work but I guess I did somethin.
Power cell in robotics
Redid piping in logistics.
Shuttle timers in evac and arrivals
Fixes intercom supply being setted towards logistics and not towards the front of logistics
Removes laika
Redid maintenance in logistics. Silent screams were heard and maintenance were expanded. Would have wanted if people actualy said it instead of gossip but eh.
Shiva is now in security and not in specificly in HoS's room, guarding it proudly.
Gives cryoxadone beaker to cryo.
Some solar panels became broken on upper solars
Changes wiring in security.
Added maintenance between security and prison. Yes, I moved the entire prison to the right, pain.
Adds a wheelchair in surgery room.
Adds EVA in evacuation.
Deleted HV wire that was going thro security and made it go thro the new maints.
Readjusts escape pod near evac.

Not sure if any of these changes are wanted but I can only assume.
God this was just pain of work but I guess I did somethin.
Power cell in robotics
Redid piping in logistics.
Shuttle timers in evac and arrivals
Fixes intercom supply being setted towards logistics and not towards the front of logistics
Removes laika
Redid maintenance in logistics. Silent screams were heard and maintenance were expanded. Would have wanted if people actualy said it instead of gossip but eh.
Shiva is now in security and not in specificly in HoS's room, guarding it proudly.
Gives cryoxadone beaker to cryo.
Some solar panels became broken on upper solars
Changes wiring in security.
Added maintenance between security and prison. Yes, I moved the entire prison to the right, pain.
Adds a wheelchair in surgery room.
Adds EVA in evacuation.
Deleted HV wire that was going thro security and made it go thro the new maints.
Readjusts escape pod near evac.

Not sure if any of these changes are wanted but I can only assume.
@deltav-mapserver
Copy link

This PR contains new or changed maps:

  • shoukou.yml

Maps are being rendered. This comment will be updated if rendering them is done.
01/04/24 22:54

@deltanedas
Copy link
Member

Removed laika

why? is it the ear powergaming

@Adrian16199
Copy link
Contributor Author

Removed laika

why? is it the ear powergaming

I simply wasnt allowed to keep both laika and shiva.

@deltanedas
Copy link
Member

laikaloose < shivaloose

@Adrian16199
Copy link
Contributor Author

laikaloose < shivaloose

You mind elaborating the opinion?

Added janitorial service lights
>engineering
>security
>medical
>Epistemics
Added light to HoS's room
Changed from arrivals screen to screens (Maybe fixes the issue idk)
@Adrian16199 Adrian16199 marked this pull request as ready for review January 5, 2024 10:30
@Adrian16199
Copy link
Contributor Author

Ready for review, need velcroboy's seal of approval and I have no idea how to request it so uh. yeah.

@Adrian16199
Copy link
Contributor Author

Why does it fail that one test tho >_>

@IamVelcroboy
Copy link
Member

Broken/bugged link

@Adrian16199
Copy link
Contributor Author

Broken/bugged link

How one would fix it because I assume that It is my issue and not the code issue.

@IamVelcroboy
Copy link
Member

IamVelcroboy commented Jan 7, 2024

It has to do with what we talked about last week with buttons/levers and whatever they're linked to being deleted.

Also, alarm linking is bugged right now too. So, if you changed/moved/added any alarm or anything linked to an alarm(vents, scrubbers, firelocks, sensors), it will cause as an error.

@Adrian16199
Copy link
Contributor Author

It has to do with what we talked about last week with buttons/levers and whatever they're linked to being deleted.

Also, alarm linking is bugged right now too. Do, if you changed/moved/added any alarm or anything linked to an alarm(vents, scrubbers, firelocks, sensors), it will cause as an error.

Oh god. I mean, regardin the first one then it wouldnt even let me save but the second one concerns me currently the most. I presume deleting the air alarm would solve it?

@IamVelcroboy
Copy link
Member

But then you'd have no air alarm. There is a way to fix it. I'm just not at my computer today. I'll help with it tomorrow.

Adrian16199 and others added 3 commits January 9, 2024 11:36
fixes rogue cable in prison
Changes piping in prison
Can invalid configurator just stop?
@Adrian16199
Copy link
Contributor Author

Im just going to redo this PR because github is just acting dumb as all hell. Constantly pulling "7" commits out of nowhere.

@Adrian16199 Adrian16199 closed this Jan 9, 2024
@Adrian16199 Adrian16199 deleted the SHoukou branch January 9, 2024 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants