-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reverts - Makes sabre sheathe use ItemSlots. #629
Conversation
It's fine as is, no? It's not inconvenient to click the belt rather than opening its inventory and pull it out |
Thing is, the current one, you have to pull it out one way by alternatively clicking it, with this, you can do like with backpacks, aka pulling out the last object that was in said storage. Its alot more convenient compared to tryin to find it on your belt while you are gettin shot compared to doin what you would do with your backpack, keybind it without lookin (so basicly the point of shethes to quickly draw a weapon) |
i thought ctrl e worked for itemslots now |
Doesnt seem to work when im tryin it. |
might just need to wait for next upstream merge then, 99% sure mirrorcult made a pr to have ctrl+e work on itemslots |
If thats the case then im probably just goin to put this on draft and just wait. If there will be such PR merged, then I will close it if its not goin to be closed by anyone else before it. |
^ I also thought this was an option so worth seeing. |
yeah might be worth reverting then, its pretty bad for a sheath to not have fast access to sword |
I'll review this during the upstream merge, and revert it if necessary during that. |
Just no.
About the PR
Reverted a PR
Why / Balance
It felt unneccesary and it doesnt really make sense for it to act like a combat boot. Also its alot more convenient.
Media
Delta-v.2024-01-01.14-11-57.mp4
Breaking changes
Changelog
Make sure to take this Changelog template out of the comment block in order for it to show up.
🆑