Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reverts - Makes sabre sheathe use ItemSlots. #629

Closed
wants to merge 2 commits into from

Conversation

Adrian16199
Copy link
Contributor

Just no.

About the PR

Reverted a PR

Why / Balance

It felt unneccesary and it doesnt really make sense for it to act like a combat boot. Also its alot more convenient.

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase
Delta-v.2024-01-01.14-11-57.mp4

Breaking changes

Changelog

Make sure to take this Changelog template out of the comment block in order for it to show up.
🆑

  • tweak: Captain's sabre sheathe works how it did previously.

@DangerRevolution
Copy link
Contributor

It's fine as is, no? It's not inconvenient to click the belt rather than opening its inventory and pull it out

@Adrian16199
Copy link
Contributor Author

Thing is, the current one, you have to pull it out one way by alternatively clicking it, with this, you can do like with backpacks, aka pulling out the last object that was in said storage. Its alot more convenient compared to tryin to find it on your belt while you are gettin shot compared to doin what you would do with your backpack, keybind it without lookin (so basicly the point of shethes to quickly draw a weapon)

@deltanedas
Copy link
Member

i thought ctrl e worked for itemslots now

@Adrian16199
Copy link
Contributor Author

i thought ctrl e worked for itemslots now

Doesnt seem to work when im tryin it.

@deltanedas
Copy link
Member

might just need to wait for next upstream merge then, 99% sure mirrorcult made a pr to have ctrl+e work on itemslots

@Adrian16199
Copy link
Contributor Author

If thats the case then im probably just goin to put this on draft and just wait. If there will be such PR merged, then I will close it if its not goin to be closed by anyone else before it.

@Adrian16199 Adrian16199 marked this pull request as draft January 1, 2024 13:43
@DangerRevolution
Copy link
Contributor

i thought ctrl e worked for itemslots now

^ I also thought this was an option so worth seeing.

@Adrian16199
Copy link
Contributor Author

Adrian16199 commented Jan 1, 2024

image

There was a PR merged regardin somesort of "smart" equipping but ctrl + E doesnt seem to work on it so ee ¯_(ツ)_/¯
Which makes me skeptical because the person you are refferncin is indeed that guy.

@Adrian16199
Copy link
Contributor Author

image
And the settings refference that the shift + E would be the smart equipping but currently on the sheathe, all it does is take out THE ENTIRE SHEATH and not the sabre

@deltanedas
Copy link
Member

yeah might be worth reverting then, its pretty bad for a sheath to not have fast access to sword

@Adrian16199 Adrian16199 marked this pull request as ready for review January 1, 2024 14:27
@DebugOk
Copy link
Contributor

DebugOk commented Jan 1, 2024

I'll review this during the upstream merge, and revert it if necessary during that.

@DebugOk DebugOk closed this Jan 1, 2024
@Adrian16199 Adrian16199 deleted the captain_sabre branch February 10, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants