Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Butlertron #61

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Butlertron #61

merged 2 commits into from
Sep 30, 2023

Conversation

DebugOk
Copy link
Contributor

@DebugOk DebugOk commented Sep 29, 2023

Mirrors #193

Changelog

🆑 PHCodes

  • add: Added Mr. Butlertron, the Roboisseur

PHCodes and others added 2 commits September 29, 2023 13:48
* Butlertron, the Robossieur

"Greetings meatbags!

This is Butlertron_Durandal, the latest in entrepreneurship technology! I have heard word that you all staff an exorbiant number of fleshlings to prepare food and drink aboard your stations. With my latest contract with your station owners, I am prepared and willing to deploy terminals to every station in the cosmos! I hope you all are ready, because there is a great deal of money to be made if you can source the dishes my discerning clientele desire."

Implements the new entity type 'Mr. Butlertron'. Mr. Butlertron requests specific foods from players, using the list of recipes available to the game. He has a blacklist of items he will not request, which fundamentally make up three categories: Simple, Disgusting, and Cannibalistic. He also has 3 tiers of foods he can request, and could be iterated upon in the future to add more tiers. Each tier increases the amount of zorkmids he will give in payment, and from the 2nd tier of food onward, he will dispense ice cream along with his dough. Take too long, however, and this affable automaton will begin to become upset, and may even lose his temper entirely, changing his request to something new. This change occurs after 10 minutes, and he begins getting impatient after 8 minutes have passed. I reused several of the scripts used by the Oracle to create Mr. Butlertron, and am hoping in the future to make him a roaming NPC, perhaps by splitting up his responsibilities into different chunks and having different 'styles' of Mr. Butlertron being able to spawn on different stations. Given that Delta-V does not have a significant amount of its own unique content and folders to support that unique content, I placed most of his files within Nyano's files.

Maybe this is not how it should be structure, and I open to suggestions.

* Changed a folder name.

I spelled my funny made up french word wrong on one folder name. Shouldn't affect anything anywhere, since .ftl folders aren't used anywhere either way.

* Update Content.Server/Nyanotrasen/Roboisseur/RoboisseurComponent.cs

Co-authored-by: DEATHB4DEFEAT <[email protected]>

* Update Content.Server/Nyanotrasen/Roboisseur/RoboisseurComponent.cs

Co-authored-by: DEATHB4DEFEAT <[email protected]>

* Apply line breaks and code from Death's code review

Co-authored-by: DEATHB4DEFEAT <[email protected]>

* Code review comment addressing.

All code review comments addressed.

* Apply suggestions from code review relating to spacing, again, and indefinite tagging. Very cool.

Co-authored-by: DEATHB4DEFEAT <[email protected]>

* Butlertron Testing and Data Field Addition

Done.

---------

Co-authored-by: DEATHB4DEFEAT <[email protected]>
@github-actions
Copy link
Contributor

RSI Diff Bot; head commit bb7b685 merging into 7d0b41a
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Structures/Machines/roboisseur.rsi

State Old New Status
roboisseur-1 Added
roboisseur-2 Added
roboisseur-3 Added
roboisseur-4 Added
roboisseur-impatient1 Added
roboisseur-impatient2 Added

@Colin-Tel
Copy link
Contributor

YOLO

@Colin-Tel Colin-Tel merged commit 9d33614 into DeltaV-Station:master Sep 30, 2023
DeltaV-Bot pushed a commit that referenced this pull request Sep 30, 2023
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
## Mirror of PR DeltaV-Station#976: [Fix Moth not eating
Jumpskirts](DeltaV-Station#976) from
<img src="https://avatars.githubusercontent.com/u/131613340?v=4"
alt="DeltaV-Station" width="22"/>
[DeltaV-Station](https://github.com/DeltaV-Station)/[Delta-v](https://github.com/DeltaV-Station/Delta-v)

<aside>PR opened by <img
src="https://avatars.githubusercontent.com/u/142105406?v=4"
width="16"/><a href="https://github.com/DangerRevolution">
DangerRevolution</a> at 2024-03-17 17:28:00 UTC</aside>
<aside>PR merged by <img
src="https://avatars.githubusercontent.com/u/142105406?v=4"
width="16"/><a href="https://github.com/DangerRevolution">
DangerRevolution</a> at 2024-03-17 17:45:11 UTC</aside>
<sup>

`0271f2ac35a433d06f761936e0d644c8a41f4548`

</sup>

---

PR changed 0 files with 0 additions and 0 deletions.

The PR had the following labels:
- Changes: YML
- Status: Needs Review


---

<details open="true"><summary><h1>Original Body</h1></summary>

> ## About the PR
> <!-- What did you change in this PR? -->
> 
> Moths can now eat jumpskirts by adding - clothmade tag
> 
> ## Why / Balance
> <!-- Why was it changed? Link any discussions or issues here. Please
discuss how this would affect game balance. -->
> 
> moths hungry
> 
> 
> ## Media
> 
> - [X] this PR does not require an ingame showcase
> 
> ## Breaking changes
> <!--
> List any breaking changes, including namespace, public
class/method/field changes, prototype renames; and provide instructions
for fixing them. This will be pasted in #codebase-changes.
> -->
> 
> **Changelog**
> :cl: DangerRevolution
> - fix: Moths can now eat skirts
> 


</details>

Co-authored-by: Danger Revolution! <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants