Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates sabre to only reflect lasers #592

Closed
wants to merge 1 commit into from
Closed

updates sabre to only reflect lasers #592

wants to merge 1 commit into from

Conversation

DangerRevolution
Copy link
Contributor

About the PR

Makes Captain's Sabre only reflect lasers; similar to the e-swords

Why / Balance

E-sword can't reflect bullets on Delta, why can the sabre?

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

🆑

  • fix: Fixed Captain's Sabre to reflect what it should

@Adrian16199
Copy link
Contributor

I mean.... I wouldnt say its a "fix", at the least give the change log to be a balance thing. If it wouldnt be a wizden thing and it genuily wouldnt suppose to do it, sure.

@DebugOk
Copy link
Contributor

DebugOk commented Dec 25, 2023

The fact it reflects anything at all makes no sense. Additionally, you're talking about an unobtainable item. The regular energy sword doesn't reflect anything afaik

@DebugOk DebugOk closed this Dec 25, 2023
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
# Description

The Ramping Event Scheduler originally followed a more or less linear
trend of "Slow events" to "Fast events", reaching its absolute maximum
event speeds at EXACTLY the point set by CVar. Additionally, the timer
CVars were set on initialization, which meant that event times could not
be modified live, thus voiding the entire benefit of having the CVars in
the first place.

I have completely rewritten the entire timer function to use a logistic
curve, which provides varying levels of transition rate from "Start",
"Mid", and "End". Shifts begin at their normal speed, and will
accelerate quickly until it reaches the "Midround", at which point event
timer growth begins to slow dramatically. Additionally, the timer
function accounts for both settings in Gamemode, as well as in CVar.
Minimum Time and Maximum Time are also now separate from each other, and
can be truly independently modified.

Finally, to show what this system is capable of, I've added a variant
"Long Survival" that can be set via admeme.

# Media

The new "Ramping Event Timer Equation". I have intentionally left this
public just in case anyone wants to use it for a different system.


![image](https://github.com/user-attachments/assets/50557a21-76ae-4b08-9cb1-edd8d991712d)

# Changelog

:cl:
- add: Long Survival has been added as a new Game mode.

---------

Signed-off-by: VMSolidus <[email protected]>
Co-authored-by: DEATHB4DEFEAT <[email protected]>
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
LaryNevesPR pushed a commit to LaryNevesPR/Estacao-Andromeda that referenced this pull request Jan 3, 2025
…V-Station#644)

# Description
This reverts commit 910b4c3.

The PR was never tested properly, and after it was merged on deep
station, a lot of significant issues have been uncovered, including
station events appearing every 6-12 seconds regardless of the gamemode,
some RampingStationEventScheduler component fields being unused, some
CVars having misleading usages, some CVars being unused, and more.

The PR needs to be re-done and tested thoroughly before it can be
merged.

:cl:
- fix: Reverted the station event scheduler rework due to it absolutely
breaking the game.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants