Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Neptune outfit submitions #583

Conversation

Neptune-Zvezda
Copy link

@Neptune-Zvezda Neptune-Zvezda commented Dec 21, 2023

About the PR

I have added 18 New Pairs of Striped Socks using the coder socks as the base
(as well as Slightly editing the old Coder Socks with 4 pixels at the top)
and added these to the Pride Vendor, in addion I have added a personal winter coat Labled as N-Parka which used the "coat" in winter coats as the base.

Why / Balance

There was only two pairs of socks and when asking others, agreed that more would be appricated

Technical details

The Pride Vendor inventory as been edited to currently hold all basic white and _____ socks while department themed have been moved to their respective "drobe"s for acquisition.

Media

Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]):
-->
Proof it fucking works
ProofHeadlockers1
ProofHeadlockers2
ProofPrideVendor
ProofSpawnMenu

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Reminder to Self and others to do not capitalize the equip-FEET.png (or other part) and icon.png files as its hard to update them to work
(will post in comments full log for access as i do not know how to link a download to the txt itself)
Changelog

Current balance changes include a adjustment to the price of the pride vendor restock to 1300 as the addions in it increase its value, this is to avoid being able to make profit by reselling bought restock crates
Current version does not have "captain" socks within the Locker as the Limit of 30 items was reached, Potential solutions include a captain drobe to move most extra clothing out of locker to clear for needed items, Alternitively adding all "socks" too their own custom Sock Vending Machine and custom Cargo Crates may work best as they are purely vanity.
Plans to Add Some Functional Sock variants Like No slips for Janitor and perhaps a storage for Sec designs for a knife

This is suffering
Should be all working but fact check it
@github-actions github-actions bot added S: Needs Review Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Dec 21, 2023
@IamVelcroboy
Copy link
Member

We need a feature, if you're wearing socks, you can slide on wood floors.

@leonardo-dabepis
Copy link
Contributor

I like the idea of this, and most of the spritework is good. I have a couple of nitpicks though.

  • Some of the icon sprites aren't centered properly. These would be Captain_Blue_and_Gold, Captain_Blue_and_White, Captain_Gold_and_Blue, Cargo, Cargo_LO-QM, Atmos, Engineering, Science, Security, White_and_Purple, White_and_Yellow, Yellow_and_Purple. The icon sprites should be in the center rather than the upper left corner.
  • Some of these items are redundant, most notably Captain_Blue_and_Gold and Captain_Gold_and_Blue. You should just choose one of those sprites and have it just be one item. Some of the other maintainers might notice other redundant items but that's just the main one that stands out to me.
  • You should probably have the job-related socks not in the pride vend but instead in each department's respective vendor and/or locker. The captain's socks especially should be moved to the captain's locker. I also say this so that the pride vend doesn't just become the sock vend, as tempting as that may be to do.
  • A lot of the item descriptions could use some work. I can go into more detail when I have more brain power, but for example one that sticks out is the item description of the N Parka, which has a gramatical mistake (it should say "A white parka with a purple N. It smells of pudding")

Other maintainers may have other things they want you to fix but that's just the stuff that stuck out to me at first glance. I'm always supportive of more customization options, so I would like to see this put in the game after a bit of polish.

@DangerRevolution
Copy link
Contributor

DangerRevolution commented Dec 21, 2023

rsi validator is saying that multiple of your sprites aren't 32x32 sized

@DangerRevolution
Copy link
Contributor

In coder.rsi, it might be just how it's formatted for me on mobile but it looks like there's a space between the r and the .?

@DangerRevolution
Copy link
Contributor

  • Some of the icon sprites aren't centered properly. These would be Captain_Blue_and_Gold, Captain_Blue_and_White, Captain_Gold_and_Blue, Cargo, Cargo_LO-QM, Atmos, Engineering, Science, Security, White_and_Purple, White_and_Yellow, Yellow_and_Purple. The icon sprites should be in the center rather than the upper left corner.
  • Some of these items are redundant, most notably Captain_Blue_and_Gold and Captain_Gold_and_Blue. You should just choose one of those sprites and have it just be one item. Some of the other maintainers might notice other redundant items but that's just the main one that stands out to me.
  • You should probably have the job-related socks not in the pride vend but instead in each department's respective vendor and/or locker. The captain's socks especially should be moved to the captain's locker. I also say this so that the pride vend doesn't just become the sock vend, as tempting as that may be to do.

I would +1 to all these points, particularly point 3 with each locker recieving their appropriate sock options as that'd be interesting for outfits! + not overwhelming pride-o-mat!

@IamVelcroboy
Copy link
Member

Add a chance for these to show up in dressers Entities/Structures/Furniture/dresser.yml

@IamVelcroboy
Copy link
Member

Oh...and washing machines Prototypes/Nyanotrasen/Entities/Structures/Machines/laundry.yml

Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Item names do not follow the requirements, do not merge without me having re-reviewed this

Moved Items to Delta V Directory as well as condensing into singular Yml files
removed all _ from names of files and reading
Copy link
Contributor

github-actions bot commented Dec 21, 2023

RSI Diff Bot; head commit dc6d416 merging into f9dd0de
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/Clothing/Under/Socks/coder.rsi

State Old New Status
equipped-FEET Modified
icon Modified

Resources/Textures/DeltaV/Clothing/OuterClothing/WinterCoats/NParka.rsi

State Old New Status
equipped-OUTERCLOTHING Added
icon Added
inhand-left Added
inhand-right Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCaptainBlueandGold.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCaptainBlueandWhite.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCaptainGoldandBlue.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCargo.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCargoQm.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedEngineering.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedEngineeringAtmos.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedScience.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedSecurity.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedSecurityJackboots.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandGreen.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandLightBlue.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandLightBlueBunnySlipper.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandOrange.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandPurple.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandRed.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandYellow.rsi

State Old New Status
equipped-FEET Added
icon Added

Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedYellowandPurple.rsi

State Old New Status
equipped-FEET Added
icon Added

Edit: diff updated after dc6d416

@Neptune-Zvezda
Copy link
Author

  • Some of the icon sprites aren't centered properly. These would be Captain_Blue_and_Gold, Captain_Blue_and_White, Captain_Gold_and_Blue, Cargo, Cargo_LO-QM, Atmos, Engineering, Science, Security, White_and_Purple, White_and_Yellow, Yellow_and_Purple. The icon sprites should be in the center rather than the upper left corner.
  • Some of these items are redundant, most notably Captain_Blue_and_Gold and Captain_Gold_and_Blue. You should just choose one of those sprites and have it just be one item. Some of the other maintainers might notice other redundant items but that's just the main one that stands out to me.
  • You should probably have the job-related socks not in the pride vend but instead in each department's respective vendor and/or locker. The captain's socks especially should be moved to the captain's locker. I also say this so that the pride vend doesn't just become the sock vend, as tempting as that may be to do.

I would +1 to all these points, particularly point 3 with each locker recieving their appropriate sock options as that'd be interesting for outfits! + not overwhelming pride-o-mat!

The Questionable Naming is more due to the fact they are different patterns which although fairly minor change how the sock may look on the person, as the Blue first merges a bit with the standard coat which gives a almost shorts feel which some may not like. The team can choose to change it to just one if felt like but i would rather the option firsthand.

@Neptune-Zvezda
Copy link
Author

I like the idea of this, and most of the spritework is good. I have a couple of nitpicks though.

  • Some of the icon sprites aren't centered properly. These would be Captain_Blue_and_Gold, Captain_Blue_and_White, Captain_Gold_and_Blue, Cargo, Cargo_LO-QM, Atmos, Engineering, Science, Security, White_and_Purple, White_and_Yellow, Yellow_and_Purple. The icon sprites should be in the center rather than the upper left corner.
  • Some of these items are redundant, most notably Captain_Blue_and_Gold and Captain_Gold_and_Blue. You should just choose one of those sprites and have it just be one item. Some of the other maintainers might notice other redundant items but that's just the main one that stands out to me.
  • You should probably have the job-related socks not in the pride vend but instead in each department's respective vendor and/or locker. The captain's socks especially should be moved to the captain's locker. I also say this so that the pride vend doesn't just become the sock vend, as tempting as that may be to do.
  • A lot of the item descriptions could use some work. I can go into more detail when I have more brain power, but for example one that sticks out is the item description of the N Parka, which has a gramatical mistake (it should say "A white parka with a purple N. It smells of pudding")

Other maintainers may have other things they want you to fix but that's just the stuff that stuck out to me at first glance. I'm always supportive of more customization options, so I would like to see this put in the game after a bit of polish.

addionally have now updated the Job based Socks to be inside the Drobe vendors for the respective jobs, addionally thanks for correcting the N parka (personal outfit), i do agree the decriptions can use work and would rather have one of the other devs suggest / tell what i could put best for them without just a overly basic "Socks that are ____ colors"
and the Sprites were uploaded wrong due to a weird software quirk with how i exported the Project file to my batch exporter and will be fixing it once they are online

@Neptune-Zvezda
Copy link
Author

  • Some of the icon sprites aren't centered properly. These would be Captain_Blue_and_Gold, Captain_Blue_and_White, Captain_Gold_and_Blue, Cargo, Cargo_LO-QM, Atmos, Engineering, Science, Security, White_and_Purple, White_and_Yellow, Yellow_and_Purple. The icon sprites should be in the center rather than the upper left corner.
  • Some of these items are redundant, most notably Captain_Blue_and_Gold and Captain_Gold_and_Blue. You should just choose one of those sprites and have it just be one item. Some of the other maintainers might notice other redundant items but that's just the main one that stands out to me.
  • You should probably have the job-related socks not in the pride vend but instead in each department's respective vendor and/or locker. The captain's socks especially should be moved to the captain's locker. I also say this so that the pride vend doesn't just become the sock vend, as tempting as that may be to do.

I would +1 to all these points, particularly point 3 with each locker recieving their appropriate sock options as that'd be interesting for outfits! + not overwhelming pride-o-mat!

@Neptune-Zvezda
Copy link
Author

Neptune-Zvezda commented Dec 21, 2023

Frick wrong buttons

Moved all Department Themed Socks to respective __-drobes Certain socks to Department Head Lockers
Last todo's Fix Image Sizes ( to be done)
add standard socks to certain random spawn pools
@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Dec 21, 2023
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

For real fixed the icons this time however test enviroment server was acting extremely unstable with ajustment of the Yml's from \ Backslashes to / forward slashes to match existing file formating
Neptune-Zvezda and others added 2 commits December 23, 2023 07:47
Fixed ID Name in Medidrobe as was not updated with ClothingUnder like other drobes
Patched N parka and atmos socks to have correct Id in Yml's to match other items
Updated N parka Names to not Include _'s to standardize naming
Changed Sock .Yml EngineeringAtmos to be / and not \  (got to read update with rename of folder)
Finally Noticed Socks was in the Id Name for Atmos Socks Twice
Captain's locker was too filed to fit the socks, moved to pride vendor until futher ideas
Socks Moved From captain locker were not given a amount to be stocked with.
@@ -66,6 +66,7 @@
- id: ClothingShoesMiscWhite # DeltaV - add fancy shoes for HoP and cap
- id: ClothingShoesBootsWinterCap #Delta V: Add departmental winter boots

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

    - id: ClothingUnderSocksStripedCaptainBlueandGold 
      prob: 0.3
      orGroup: socks 
    - id: ClothingUnderSocksStripedCaptainBlueandWhite 
      prob: 0.3
      orGroup: socks 
    - id: ClothingUnderSocksStripedCaptainBlueandWhite 
      prob: 0.3
      orGroup: socks 

Adjusted Cost of pride restock as with addion of "captain" socks went over the cost limit
Copy link
Contributor

@Colin-Tel Colin-Tel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Take a look over these and consider them. If they're alright with you, then please do these changes in one batch or I'll cry.

Neptune-Zvezda and others added 10 commits January 16, 2024 08:00
@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Jan 21, 2024
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Neptune-Zvezda Neptune-Zvezda deleted the Neptune-Outfit-Submitions branch January 28, 2024 23:38
@Neptune-Zvezda Neptune-Zvezda restored the Neptune-Outfit-Submitions branch January 30, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Merge Conflict Fix your PR! S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants