-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Neptune outfit submitions #583
Neptune outfit submitions #583
Conversation
This is suffering
Should be all working but fact check it
We need a feature, if you're wearing socks, you can slide on wood floors. |
I like the idea of this, and most of the spritework is good. I have a couple of nitpicks though.
Other maintainers may have other things they want you to fix but that's just the stuff that stuck out to me at first glance. I'm always supportive of more customization options, so I would like to see this put in the game after a bit of polish. |
rsi validator is saying that multiple of your sprites aren't 32x32 sized |
In coder.rsi, it might be just how it's formatted for me on mobile but it looks like there's a space between the r and the .? |
I would +1 to all these points, particularly point 3 with each locker recieving their appropriate sock options as that'd be interesting for outfits! + not overwhelming pride-o-mat! |
Add a chance for these to show up in dressers |
Oh...and washing machines |
Resources/Prototypes/DeltaV/Catalog/VendingMachines/Inventories/pride.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Catalog/VendingMachines/Inventories/pride.yml
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Item names do not follow the requirements, do not merge without me having re-reviewed this
Moved Items to Delta V Directory as well as condensing into singular Yml files
removed all _ from names of files and reading
RSI Diff Bot; head commit dc6d416 merging into f9dd0de Resources/Textures/Clothing/Under/Socks/coder.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/WinterCoats/NParka.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCaptainBlueandGold.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCaptainBlueandWhite.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCaptainGoldandBlue.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCargo.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedCargoQm.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedEngineering.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedEngineeringAtmos.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedScience.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedSecurity.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedSecurityJackboots.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandGreen.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandLightBlue.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandLightBlueBunnySlipper.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandOrange.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandPurple.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandRed.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedWhiteandYellow.rsi
Resources/Textures/DeltaV/Clothing/Under/Socks/ClothingUnderSocksStripedYellowandPurple.rsi
|
The Questionable Naming is more due to the fact they are different patterns which although fairly minor change how the sock may look on the person, as the Blue first merges a bit with the standard coat which gives a almost shorts feel which some may not like. The team can choose to change it to just one if felt like but i would rather the option firsthand. |
addionally have now updated the Job based Socks to be inside the Drobe vendors for the respective jobs, addionally thanks for correcting the N parka (personal outfit), i do agree the decriptions can use work and would rather have one of the other devs suggest / tell what i could put best for them without just a overly basic "Socks that are ____ colors" |
|
Frick wrong buttons |
Moved all Department Themed Socks to respective __-drobes Certain socks to Department Head Lockers Last todo's Fix Image Sizes ( to be done) add standard socks to certain random spawn pools
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
For real fixed the icons this time however test enviroment server was acting extremely unstable with ajustment of the Yml's from \ Backslashes to / forward slashes to match existing file formating
Fixed ID Name in Medidrobe as was not updated with ClothingUnder like other drobes
Patched N parka and atmos socks to have correct Id in Yml's to match other items
Updated N parka Names to not Include _'s to standardize naming
Changed Sock .Yml EngineeringAtmos to be / and not \ (got to read update with rename of folder)
Finally Noticed Socks was in the Id Name for Atmos Socks Twice
Captain's locker was too filed to fit the socks, moved to pride vendor until futher ideas
Resources/Prototypes/DeltaV/Catalog/VendingMachines/Inventories/pride.yml
Outdated
Show resolved
Hide resolved
Socks Moved From captain locker were not given a amount to be stocked with.
@@ -66,6 +66,7 @@ | |||
- id: ClothingShoesMiscWhite # DeltaV - add fancy shoes for HoP and cap | |||
- id: ClothingShoesBootsWinterCap #Delta V: Add departmental winter boots | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- id: ClothingUnderSocksStripedCaptainBlueandGold
prob: 0.3
orGroup: socks
- id: ClothingUnderSocksStripedCaptainBlueandWhite
prob: 0.3
orGroup: socks
- id: ClothingUnderSocksStripedCaptainBlueandWhite
prob: 0.3
orGroup: socks
Adjusted Cost of pride restock as with addion of "captain" socks went over the cost limit
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Take a look over these and consider them. If they're alright with you, then please do these changes in one batch or I'll cry.
Resources/Prototypes/DeltaV/Entities/Clothing/Under/StripedSock.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Clothing/Under/StripedSock.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Clothing/Under/StripedSock.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Clothing/Under/StripedSock.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Clothing/Under/StripedSock.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Clothing/Under/StripedSock.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Clothing/Under/StripedSock.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Clothing/Under/StripedSock.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Clothing/Under/StripedSock.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Clothing/Under/StripedSock.yml
Outdated
Show resolved
Hide resolved
…k.yml Co-authored-by: Colin-Tel <[email protected]> Signed-off-by: Neptune <[email protected]>
…k.yml Co-authored-by: Colin-Tel <[email protected]> Signed-off-by: Neptune <[email protected]>
…k.yml Co-authored-by: Colin-Tel <[email protected]> Signed-off-by: Neptune <[email protected]>
…k.yml Co-authored-by: Colin-Tel <[email protected]> Signed-off-by: Neptune <[email protected]>
…k.yml Co-authored-by: Colin-Tel <[email protected]> Signed-off-by: Neptune <[email protected]>
…k.yml Co-authored-by: Colin-Tel <[email protected]> Signed-off-by: Neptune <[email protected]>
…k.yml Co-authored-by: Colin-Tel <[email protected]> Signed-off-by: Neptune <[email protected]>
…k.yml Co-authored-by: Colin-Tel <[email protected]> Signed-off-by: Neptune <[email protected]>
…k.yml Co-authored-by: Colin-Tel <[email protected]> Signed-off-by: Neptune <[email protected]>
…k.yml Co-authored-by: Colin-Tel <[email protected]> Signed-off-by: Neptune <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
…e-Zvezda/Delta-v-Nep-fuckery into Neptune-Outfit-Submitions
About the PR
I have added 18 New Pairs of Striped Socks using the coder socks as the base
(as well as Slightly editing the old Coder Socks with 4 pixels at the top)
and added these to the Pride Vendor, in addion I have added a personal winter coat Labled as N-Parka which used the "coat" in winter coats as the base.
Why / Balance
There was only two pairs of socks and when asking others, agreed that more would be appricated
Technical details
The Pride Vendor inventory as been edited to currently hold all basic white and _____ socks while department themed have been moved to their respective "drobe"s for acquisition.
Media
Check the box below to confirm that you have in fact seen this (put an X in the brackets, like [X]):
-->
Breaking changes
Reminder to Self and others to do not capitalize the equip-FEET.png (or other part) and icon.png files as its hard to update them to work
(will post in comments full log for access as i do not know how to link a download to the txt itself)
Changelog
Current balance changes include a adjustment to the price of the pride vendor restock to 1300 as the addions in it increase its value, this is to avoid being able to make profit by reselling bought restock crates
Current version does not have "captain" socks within the Locker as the Limit of 30 items was reached, Potential solutions include a captain drobe to move most extra clothing out of locker to clear for needed items, Alternitively adding all "socks" too their own custom Sock Vending Machine and custom Cargo Crates may work best as they are purely vanity.
Plans to Add Some Functional Sock variants Like No slips for Janitor and perhaps a storage for Sec designs for a knife