Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Three-Sword Style #582

Closed
wants to merge 5 commits into from

Conversation

ps3moira
Copy link
Contributor

About the PR

Made katana's able to be equipped in the mask-slot.

Why / Balance

Because it's cool.

Media

Screenshot 2023-12-20 193608
Screenshot 2023-12-20 192640
DULL VERSION.
Screenshot 2023-12-20 192658
REAL VERSION.

  • I have added screenshots/videos to this PR showcasing its changes ingame
    Changelog
    🆑
  • add: Added Three-Sword Style. Katana's can now be equipped in the mask-slot.

@github-actions github-actions bot added S: Needs Review Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files labels Dec 21, 2023
Copy link
Contributor

github-actions bot commented Dec 21, 2023

RSI Diff Bot; head commit b6e2b5e merging into 10a1433
This PR makes changes to 1 or more RSIs. Here is a summary of all changes:

Resources/Textures/DeltaV/Objects/Weapons/Melee/katana.rsi

State Old New Status
equipped-MASK Added

Resources/Textures/Objects/Weapons/Melee/katana.rsi

State Old New Status
equipped-MASK Added

Edit: diff updated after b6e2b5e

Copy link
Contributor

@DebugOk DebugOk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks ridiculous and doesn't fit at all, so consider this my disapproval of this. Unless Colin thinks otherwise

@DebugOk DebugOk requested review from VMSolidus and removed request for Colin-Tel February 12, 2024 21:04
@DebugOk
Copy link
Contributor

DebugOk commented Feb 12, 2024

@VMSolidus You're the only other person I have to ask right now, since my older comment was made when Colin still had write access.

I think this sprite looks silly, and I dont like it. Whats your opinion on it?

@VMSolidus
Copy link
Contributor

So I'll be honest, as much as I talk about using mecha anime for reference art, I'm not actually that big of an anime fan. I really don't like these sprites that much at all, not just because they're silly, but also on a technical level. I know this server likes to have the strange and unusual stuff, but carrying a sword in your mouth is a little too out there even for us, it's just having a one-piece reference for the sake of the reference.

@VMSolidus
Copy link
Contributor

I'm going to close this as I do not feel that this feature is a good fit for this server.

@VMSolidus VMSolidus closed this Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: Sprite Changes any png or json in an rsi Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants