Boots #572
Merged
Boots #572
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
December 13, 2023 02:25
This reverts commit 2e1c7ce.
github-actions
bot
added
S: Needs Review
Changes: Sprite
|
RSI Diff Bot; head commit 64a3835 merging into 9989602 Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsatmos.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootscap.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsce.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootscentcom.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootschef.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootschem.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsclown.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootscmo.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsgen.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootshop.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootshos.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootshydro.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsjani.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsmime.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsminer.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsparamed.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsqm.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsrd.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsrobo.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootsviro.rsi
Resources/Textures/DeltaV/Clothing/Shoes/Boots/winterbootswarden.rsi
|
added 2 commits
December 18, 2023 16:39
Colin-Tel
approved these changes
Dec 21, 2023
DeltaV-Bot
pushed a commit
that referenced
this pull request
Dec 21, 2023
DebugOk
pushed a commit
to DebugOk/Delta-v
that referenced
this pull request
Jan 20, 2024
(cherry picked from commit af2cdd2)
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 3, 2025
…ltaV-Station#572) # Description For reasons unknown, AdminManager has two command permission managers: _commandPermissions and _toolshedCommandPermissions. It used to load normal command permissions into the former, and toolshed command permissions into the latter. Since _toolshedCommandPermissions is NEVER actually used in checking whether a player can execute a command, all toolshed commands remained unavailable to anyone without +HOST. This PR provides a bandaid fix for that: it makes it so that the same permissions are loaded into both managers at the same time. It's necessary to load them into _commandPermissions in order to allow regular players to execute them, and it's also necessary to load them into _toolshedCommandPermissions because otherwise the ToolshedManager will complain about those commands lacking permission flags. This should also fixes some commands such as `spawn`, `pos`, `comp` being inaccessible to admins with +DEBUG and more. <details><summary><h1>Media</h1></summary><p>   Admin-only commands are unaffected:  </p></details> --- # Changelog :cl: - fix: Fixed toolshed command permissions. This will mostly affect admins who don't have full host access.
LaryNevesPR
pushed a commit
to LaryNevesPR/Estacao-Andromeda
that referenced
this pull request
Jan 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds the rest of the winter boots Wizden turned down. Donated graciously by Kilk. Thanks!
Why / Balance
Winter drip be cozy
Technical details
n/a
Media
Was discussed in Discord but let me know if you really need to see them again.
Breaking changes
n/a
Changelog
🆑 Velcroboy and Kilk