Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bureaucratic error changes #532

Merged
merged 3 commits into from
Feb 12, 2024

Conversation

Guess-My-Name
Copy link
Contributor

About the PR

reenables bureaucratic error event and changes it to a bit less chaos -- no more closing all jobs except a single unlimited one

Why / Balance

Technical details

Media

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

  • add: Some budget cuts were made in HR department, expect more bureaucratic errors in near future.

@github-actions github-actions bot added S: Needs Review Changes: C# Changes any cs files Changes: YML Changes any yml files labels Dec 9, 2023
@DangerRevolution
Copy link
Contributor

I've never seen this event before so I'm curious how this plays out. Will be interesting to see!

@OCOtheOmega
Copy link
Contributor

YAML Linter go brrrr

@Adrian16199
Copy link
Contributor

10 captains on a shift, would be funny.

@ps3moira
Copy link
Contributor

ps3moira commented Dec 9, 2023

This event was pretty unfun, what's the difference to the version that got removed? Other than limiting to no jobs at all or unlimited jobs.

@DangerRevolution
Copy link
Contributor

This event was pretty unfun, what's the difference to the version that got removed? Other than limiting to no jobs at all or unlimited jobs.

Doesn't close all job slots. That's all..

@deltanedas
Copy link
Member

ftr thats a rate event that only has 25% chance at max modifier, its much lower otherwise
forcing latejoins to all be clowns is funy

removed whitespace likely causing test failures

Signed-off-by: Colin-Tel <[email protected]>
@Colin-Tel
Copy link
Contributor

fixed the errors in this PR

Copy link

@Elijahrane Elijahrane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@DebugOk DebugOk merged commit 0451fc6 into DeltaV-Station:master Feb 12, 2024
10 checks passed
DeltaV-Bot pushed a commit that referenced this pull request Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants