-
Notifications
You must be signed in to change notification settings - Fork 340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hair! #51
Hair! #51
Conversation
RSI Diff Bot; head commit ac379dd merging into d0a4745 Resources/Textures/DeltaV/Mobs/Customization/hair.rsi
|
Actually probably all the fades |
Classic High fade is indistinguishable from High fade, at least to me it is.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
this meta file SUCKS |
Signed-off-by: Colin-Tel <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
You ever gonna finish this? Or do we close it for now |
I was intending on keeping it open until people find more hairstyles, so it could all be in one PR, but I think I'll just send it with the few hairstyles we've found so far. |
Moved the added hairstyles to Delta directory
whitespace
untouched the file Signed-off-by: Colin-Tel <[email protected]>
why didn't it do this last commit grrr aaah
Fully removed the added hairstyles from any upstream files.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except the fact that they don't follow the same naming convention?
HumanHairBobClassic = Bob Hair Classic
HumanHairClassicGentle = Classic Gentle
lol that is true, because I merged the PR that added those hairstyles like 10 minutes before I finished this PR, and prior to that there was no precedent set. |
I'm fine with having Classic Gentle becoming Gentle Classic, but Classic Fade (Medium) into Fade Classic (Medium) just rubs me the wrong way. |
per floofy review Signed-off-by: Colin-Tel <[email protected]>
About the PR
Things are about to get hairy.
This PR is for adding the hairstyles that were "modernized" that look subjectively better than their replacements.
It is intended that this PR remains a draft until players are able to play on the rebase version, and they are then able to point out which hairstyles should make a return. (either in a PR comment, in the Discord, or otherwise)yeah that didn't happen lolTechnical details
Prettified the human_hair.rsi
meta.json
so it doesn't look terrible.Media