-
Notifications
You must be signed in to change notification settings - Fork 338
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Playable Species: Lamia #479
Conversation
RSI Diff Bot; head commit a3b4ca5 merging into 6f4f31f Resources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertengineer.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertjanitor.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertleader.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertmedical.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/ERTSuits/ertsecurity.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/atmospherics.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/basic.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/brigmedic.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/capspace.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/cybersun.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/deathsquad.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/engineering-white.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/engineering.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/lingspacesuit.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/luxury.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/medical.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/paramed.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/piratecaptain.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/pirateeva.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/rd.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/salvage.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/santahardsuit.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/security-red.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/security-warden.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/spatio.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/syndicate.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/syndiecommander.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/syndieelite.rsi
Resources/Textures/Clothing/OuterClothing/Hardsuits/syndiemedic.rsi
Resources/Textures/Clothing/OuterClothing/Suits/ancient_voidsuit.rsi
Resources/Textures/Clothing/OuterClothing/Suits/atmos_firesuit.rsi
Resources/Textures/Clothing/OuterClothing/Suits/bombsuit.rsi
Resources/Textures/Clothing/OuterClothing/Suits/eva.rsi
Resources/Textures/Clothing/OuterClothing/Suits/eva_emergency.rsi
Resources/Textures/Clothing/OuterClothing/Suits/eva_prisoner.rsi
Resources/Textures/Clothing/OuterClothing/Suits/eva_syndicate.rsi
Resources/Textures/Clothing/OuterClothing/Suits/fire.rsi
Resources/Textures/Clothing/OuterClothing/Suits/rad.rsi
Resources/Textures/Clothing/OuterClothing/Suits/spaceninja.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/Combat/advanced.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/Combat/corpsman.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/Combat/hos.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/Combat/medical.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/Combat/officer.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/Combat/riot.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/Combat/standard.rsi
Resources/Textures/DeltaV/Clothing/OuterClothing/Hardsuits/Combat/warden.rsi
Resources/Textures/DeltaV/Mobs/Customization/Lamia/lamia_tails.rsi
Resources/Textures/Nyanotrasen/Mobs/Effects/Lamia/brute_damage.rsi
Resources/Textures/Nyanotrasen/Mobs/Effects/Lamia/burn_damage.rsi
Resources/Textures/Nyanotrasen/Mobs/Species/lamia.rsi
|
Already provided some tips re: event networking in Discord DMs.
Can you post the problem you are trying to solve with this? I think there's probably a better solution.
You don't want to do this via spawning extra entities. The hardsuits can be probably be visual, just adding a layer like clothes do, and the second one can just be done via AccessComponent. |
So even more entities that aren't needed. They shouldn't be spawning any new entities for putting on stuff, and only referencing the main lamia entity |
Well the code no longer works again. I should say the server works fine, but the client now crashes to desktop on startup. I started work on changing out the sprite fuckery for a Visualizer, which will apparently make things easier for me. A lot easier actually. |
I've gone ahead and updated the TODO list to reflect new feedback and assistance regarding the development process. This should now accurately state all the tasks that need to be completed for Lamia to be merged. |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
I have just checked off FOUR of the requirements in the past 4 hours.
Visuals for hardsuits are still not final, and require sprites to be made. However they DO WORK. |
I'm ditching the requirement for access-code inheritance since that will require changing an unholy amount of upstream code, which I am unwilling to do for the sake of a species. Lamia greyshirts will simply need to learn to deal with making sure they can get through a door without having it slam on their tail while trying to tailgate their way into security. That is going to leave finishing up the last of their necessary sprites, and some code touchups. Lamia are now 95% complete. |
In order to address the need for fine tuning, I instead made an enormous math equation to derive their damage modifiers from their tail length(which is itself a variable that can be set for the sake of server performance). |
portal.bug.fixed.mp4The portal bug is now fixed. Lamia are now able to use portals. |
Known Issues:
|
Maybe find some people interested in helping break Lamia by the time you're ready to test them again |
* Updated rules 2-5, 2-10, 3-4, 4-8, 6-2, 8-4. * Added a summary. * Update Rules.txt Signed-off-by: Debug <[email protected]> --------- Signed-off-by: Debug <[email protected]> Co-authored-by: Debug <[email protected]>
Fixes the Boxer room's access so that a boxer can actually enter it, also slight changes to the dojo.
* fix warp points, bombing sites, added mcgriff, paramed job. * fix solution smh * added screens and service lights, cargo docks less narrow
Signed-off-by: Debug <[email protected]>
Co-authored-by: Jeff <[email protected]>
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
About the PR
This is a draft PR for an upcoming new playable species, the Lamia. Lamia are an older species from the 2022 era of Nyanotrasen, and were previously abandoned code that was dropped from the game on October 13th, 2022. I was able to locate what I believe to be the last remaining branch containing Lamia, from a defunct server repository that ran an October 12th, 2022 build of Nyanotrasen. Thus I began a project to refurbish this code for use on modern SS14.
The Lamia I wish to PR are only recognizable from the original Lamia in that they share the Tail Segment System. That is, they prominently feature a completely unique mechanic whereby their body is composed of multiple entities linked together in a chain. The original version of this code had a great many bugs related to the game's physics system, and it was severely limited by the Robust Toolbox engine at the time. In the year since Lamia's abandonment, Robust Toolbox has gone through many iterations and improvements, and has deprecated large parts of the physics system that old Lamia utilized.
Redesigns from the original 2022 Lamia, AKA Nyanotrasen Lamia. Vs. DeltaV Lamia
The original Nyanotrasen Lamia were made with several limitations in mind. Their size was heavily restricted by the physics engine at the time, we aren't beholden to that same limitation anymore. Thus DeltaV Lamia are vastly larger than the Nyanotrasen Lamia, featuring a tail that is 5 tiles in length, with fully functional physics collisions. They were also not able to wear Hardsuits due to limitations of the SpriteComponent, and thus were instead designed around having a "Barotrauma resistance". On DeltaV code, we can arbitrarily state that species use different optional sprites for items, therefore its possible to have for example a Nukie Hardsuit, with its equipped-outerwear state, equipped-outerwear-lamia, equipped-outerwear-lamiainitialsegment, equipped-outerwear-lamiasegment, and so on. The Lamia Segments can simply state that if they equip a hardsuit, they utilize the -lamiasegment sprite option. Therefore its no longer necessary to create an entire new item solely so that snakes can wear a hardsuit.
Positive Traits
Negative Traits
Why / Balance
This PR is part of an ongoing project to add exciting new content to the DeltaV repository, with a focus on keeping the theme of "Monster People" species, per request by admins.
Technical details
The code regarding Tail Segments is actually unfinished, and still needs significant overhauling before this PR can be undrafted. Here's a few concerns:
Non-Technical TODO list
These are all the TODO's that don't necessarily involve C#, and primarily live in the YAML side of things.
Media
One of the downsides of having extreme mass.
Working Collision physics:
Changelog
🆑 VMSolidus, @Elijahrane, and @noctyrnal