Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cap mass media articles #45

Closed
wants to merge 3 commits into from
Closed

Conversation

BasedUser
Copy link
Contributor

no more 500px wide images, no more network lag

About the PR

This PR caps the maximum news article size to 32KB, dampening network lag severely.
Client lag is also nonexistent now - previously occured at about 500KB on my relatively low end graphics card (Radeon HD 6850).
Mirrors Delta-v#202.

Media
image
after applying a clientside cap
image

  • I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Changelog
no cl no fun

@github-actions
Copy link
Contributor

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the S: Merge Conflict Fix your PR! label Sep 27, 2023
@github-actions github-actions bot removed the S: Merge Conflict Fix your PR! label Sep 28, 2023
@DebugOk
Copy link
Contributor

DebugOk commented Sep 29, 2023

This doesnt work in its current state, and it might be better to upstream it

@BasedUser
Copy link
Contributor Author

ok i'm blind give me some time to begin the killing

@deltanedas
Copy link
Member

should just limit text to like 2kb and have a dedicated thing for adding images since clearly its a nice thing without needing a java script
also upstream killer

@DebugOk
Copy link
Contributor

DebugOk commented Oct 5, 2023

Stale, and probably should be upstreamed. Reopen if/when fixes get made

@DebugOk DebugOk closed this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants