Drunkard accent #2698
Open
Drunkard accent #2698
+99
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this uses a modified version of SlurredSystem's Accentuate for the trait with hardcoded values and removing the burping and "huh" additions. the functionality *could* be extracted into a static method, however it would require changing code in non-Floof code when this works perfectly fine
github-actions
bot
added
Changes: YML
deltanedas
requested changes
Jan 11, 2025
| return sb.ToString(); | ||
| } | ||
|
|
||
| private void OnAccent(EntityUid uid, DrunkardAccentComponent component, AccentGetEvent args) |
There was a problem hiding this comment.
use Entity<DrunkardAccentComponent> ent
|
|
||
| public sealed class DrunkardAccentSystem : EntitySystem | ||
| { | ||
| [Dependency] private readonly StatusEffectsSystem _statusEffectsSystem = default!; |
|
|
||
| namespace Content.Server._DV.Speech.EntitySystems; | ||
|
|
||
|
|
There was a problem hiding this comment.
only 1 blank line here not 2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Adds a "drunkard accent", a trait that makes a character's speech slurred like they're drunk.
Port of Fansana/floofstation1#476
Why / Balance
There are a few alcoholic characters that would benefit from being "constantly drunk" without the actual status effect. This could be a good effect for other characters that have a speech impediment.
Technical details
This uses a modified version of SlurredSystem's Accentuate for the trait with hardcoded values and removing the burping and "huh" additions. The functionality could be extracted into a static method, however it would require changing code in non-Floof code when this works perfectly fine; reducing changes to the codebase is preferable.
If the character is drunk past a certain point, the SlurredSpeech effect will take precedence over DrunkardAccent.
Media
Requirements
Breaking changes
Changelog
🆑