Removes Senior Roles

[FluffiestFloof]

About the PR

It comments out all the senior roles and set the ability to set their preference to false.

Why / Balance

Technical details

Media

• I have added screenshots/videos to this PR showcasing its changes ingame, or this PR does not require an ingame showcase

Breaking changes

Changelog

🆑

• remove: The Senior Roles are no longer available at round start.

[FluffiestFloof]

The real question is, do we want them to be potentially late join or entirely gone?

[Colin-Tel]

Failed InvalidRoundstartJobsTest [70 ms]
  Error Message:
   Multiple failures or warnings in test:
  1)   Station Boxstation contains job prototype SeniorEngineer which cannot be present roundstart.
  Expected: not some item equal to "SeniorEngineer"
  But was:  < "ERTMedical", "CentralCommandOfficial", "ERTEngineer", "SeniorEngineer", "SeniorPhysician", "ERTJanitor", "ERTLeader", "SeniorResearcher", "ERTSecurity", "SeniorOfficer" >

Looks like we may have to comment out senior roles on maps. I can get started on it in a few minutes.

[Colin-Tel]

The real question is, do we want them to be potentially late join or entirely gone?

I think entirely gone is probably the route to take. We have no desire to really keep them in game. We'll just comment them out until we decide otherwise.

[FluffiestFloof]

The real question is, do we want them to be potentially late join or entirely gone?

I think entirely gone is probably the route to take. We have no desire to really keep them in game. We'll just comment them out until we decide otherwise.

I'll deal with entirely commenting out the senior roles then.
Also it's weird that they create errors, is only late join roles a Nyano thing?

[IamVelcroboy]

Nyano does have some code that touches late join. Rane did something so roles like Prisoner/Gladiator/etc spawn where the marker is and not at the late join spot in arrivals.

Not sure if that's relevant here or not.

[DebugOk]

The real question is, do we want them to be potentially late join or entirely gone?

I think entirely gone is probably the route to take. We have no desire to really keep them in game. We'll just comment them out until we decide otherwise.

Do not. This is because of the stations

[DebugOk]

Comment them out in the station prototypes, not the jobs themselves

[Colin-Tel]

Comment them out in the station prototypes, not the jobs themselves

Right, that's what I meant haha.

[DebugOk]

Recent merge added back incorrect entries into the map prototypes