Add history tab to bounty console #2473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Changes: UI
Changes: C#
|
remove the deltav comments as it will just make merging upstream more annoying instead of just being skipped |
You want me to keep the files in DeltaV places or just remove the comments. |
|
just use the upstream commits as-is dont have comments or file changes (then thered be duplicate files when merging master, also bad) |
BarryNorfolk
force-pushed
the
bounty/history
branch
from
3e69a82 to
3bb6da3
Compare
|
Done. |
deltanedas
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
About the PR
Added a history tab to the cargo bounty console.
DeltaV port of space-wizards/space-station-14#33932. Just cherry picked the changes across and added an extra commit for adding DeltaV comments literally everywhere.
Why / Balance
Knowing whether or not any bounties have been completed and when is important for people in charge of logistics, or command for that matter. It's also important to know who skipped what bounties so people can either teach which ones to not skip, or nod sagely at their good skip choices.
Technical details
New to the codebase and C# in general, but seemed somewhat straightforward to add.
Media
Requirements
Breaking changes
🆑